Repository navigation
fix: keep package identities in variants (SPEC-T01) - #95
Merged
Merged
Conversation
Contributor
✅ TropiBot report: SYNC TEST REPORT - PASSEDThis CI runs on a real DAppNode using the same RPC calls a user would make to configure a staker setup: execution client, consensus client, web3signer, MEV-boost, and relays. 📦 Package Under Test
📦 Clients Used
🔖 Version Tracking
⏱️ Timing
Total Duration: 1m 59s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Correct SPEC-T01 from the package specification checks.
Based on the default branch
main.Approach
Keep package identities in the variant manifests and remove the phantom root identity. Preserve every effective variant name and version.
Test instructions
Run the SDK package-spec validation on this branch for all package variants.
Verified locally:
docker compose config --quietpass for every variant.git diff --checkand replay of the complete PR stack pass.Full container images were not built locally.