Skip to content

fix: remove fixed service container names (SPEC-C02) - #82

Merged
3alpha merged 1 commit into
fix/spec-t01-variant-identitiesfrom
fix/spec-c02-container-names
Nov 9, 2026
Merged

3alpha merged 1 commit into
fix/spec-t01-variant-identitiesfrom
fix/spec-c02-container-names

Conversation

@3alpha

@3alpha 3alpha commented Nov 9, 2026

Copy link
Copy Markdown
Member

Context

Correct SPEC-C02 from the package specification checks.

Stacked on #81 (base fix/spec-t01-variant-identities). Merge the base PR first; this diff contains only the next focused fix.

Approach

Remove fixed container names from package services; DAPPMANAGER supplies those names at installation. Keep empty variant service overrides as {} so they still inherit the root service.

Test instructions

Run the SDK package-spec validation on this branch for all package variants.

Verified locally:

  • SDK loading and manifest/optional-asset schemas pass for all 3 variants.
  • Release-file generation, avatar verification and docker compose config --quiet pass for every variant.
  • Compared effective service settings, image/version pins and package identities with the parent: preserved.
  • git diff --check and replay of the complete PR stack pass.
  • SPEC-C02 findings in this layer: 6 → 0.

Full container images were not built locally.

@3alpha
3alpha added this pull request to stack #83 November 9, 2026 12:13
@3alpha
3alpha merged commit 256bf87 into main Nov 9, 2026
3 checks passed
@3alpha
3alpha deleted the fix/spec-c02-container-names branch November 9, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant