Skip to content

fix: keep package identities in variants (SPEC-T01) - #33

Merged
3alpha merged 1 commit into
mainfrom
fix/spec-t01-variant-identities
Nov 9, 2026
Merged

3alpha merged 1 commit into
mainfrom
fix/spec-t01-variant-identities

Conversation

@3alpha

@3alpha 3alpha commented Nov 9, 2026

Copy link
Copy Markdown
Member

Context

Correct SPEC-T01 from the package specification checks.

Stacked on #32 (base fix/spec-f01-release-assets). Merge the base PR first; this diff contains only the next focused fix.

Approach

Keep package identities in the variant manifests and remove the phantom root identity. Preserve every effective variant name and version.

Test instructions

Run the SDK package-spec validation on this branch for all package variants.

Verified locally:

  • SDK loading and manifest/optional-asset schemas pass for all 2 variants.
  • Release-file generation, avatar verification and docker compose config --quiet pass for every variant.
  • Compared effective service settings, image/version pins and package identities with the parent: preserved.
  • git diff --check and replay of the complete PR stack pass.
  • SPEC-T01 findings in this layer: 1 → 0.

Full container images were not built locally.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 6f05a4c

This is a development version and should only be installed for testing purposes.

  1. Package pathfinder-sepolia.dnp.dappnode.eth

Install link

Hash: /ipfs/QmdMpr1XeCJ3cAwTpU7owhZZ6J9BSZcMiGXCa5Vozo6cDf

(by dappnodebot/build-action)

@3alpha
3alpha added this pull request to stack #34 November 9, 2026 12:11
Base automatically changed from fix/spec-f01-release-assets to main November 9, 2026 12:12
@3alpha
3alpha force-pushed the fix/spec-t01-variant-identities branch from 6f05a4c to 9dcbf1e Compare November 9, 2026 12:12
@3alpha
3alpha merged commit 5f560a0 into main Nov 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant