Skip to content

fix: use build argument mappings (SPEC-C05) - #16

Merged
3alpha merged 1 commit into
fix/spec-m03-upstream-metadatafrom
fix/spec-c05-build-args
Nov 9, 2026
Merged

3alpha merged 1 commit into
fix/spec-m03-upstream-metadatafrom
fix/spec-c05-build-args

Conversation

@3alpha

@3alpha 3alpha commented Nov 9, 2026

Copy link
Copy Markdown
Member

Context

Correct SPEC-C05 from the package specification checks.

Stacked on #15 (base fix/spec-m03-upstream-metadata). Merge the base PR first; this diff contains only the next focused fix.

Approach

Replace list-style build arguments with a mapping while preserving every argument name and exact string value. Core package container names remain unchanged.

Test instructions

Run the SDK package-spec validation on this branch for all package variants.

Verified locally:

  • SDK loading and manifest/optional-asset schemas pass for all 1 variant.
  • Release-file generation, avatar verification and docker compose config --quiet pass for every variant.
  • Compared effective service settings, image/version pins and package identities with the parent: preserved.
  • git diff --check and replay of the complete PR stack pass.
  • SPEC-C05 findings in this layer: 1 → 0.

Full container images were not built locally.

@tropibot

tropibot Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Dappnode bot has built and pinned the built packages to an IPFS node, for commit: a44a3c1

This is a development version and should only be installed for testing purposes.

  1. Package pi-hole.dnp.dappnode.eth

Install link

Hash: /ipfs/QmPXJVhn2sismzpVixZNpQmVfmGweMEHdU2t2A8oocF6nR

(by dappnodebot/build-action)

@3alpha
3alpha added this pull request to stack #17 November 9, 2026 12:09
@3alpha
3alpha merged commit ca9872e into master Nov 9, 2026
2 checks passed
@3alpha
3alpha deleted the fix/spec-c05-build-args branch November 9, 2026 12:10
@tropibot

tropibot Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

🛠️ Package harness hit an infrastructure error

MCP tool 'dappnode_fetch_install_preview' failed: Error: MultiUrlJsonRpcProvider: all RPC endpoints failed for method "eth_call". Last errors: - http://beacon-chain.mainnet.dncore.dappnode:3500: TypeError: fetch failed - https://web3.dappnode.net: Error: execution reverted (unknown custom error) (action="call", data="0x5fe9a5df0000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000001a0770692d686f6c6503646e700864…[truncated]

Package Verdict Reason Duration Cleanup
pi-hole.dnp.dappnode.eth 🛠️ Infrastructure error Baseline unavailable (baseline_unavailable) 0s ⏭️ Skipped

Run overview

Context Value
Pull request dappnode/DAppNodePackage-pi-hole#16
Tested commit a44a3c1cccd8
Candidate artifact Install on DAppNode · /ipfs/QmPXJVhn2sismzpVixZNpQmVfmGweMEHdU2t2A8oocF6nR
Baseline request automatic
Worker dappnode-near-5
Run ID gh-pr-16-a44a3c1cccd8-2c0b5784e6609f93
Execution 2026-11-09T12:33:29.566045051+00:00 → 2026-11-09T12:33:30.429971307+00:00 (✅ Completed)

Baseline vs candidate

Check Baseline Candidate
Version unavailable not reported
Install ❌ Failed · 0s ❌ Failed · 0s
Hard check ❌ Failed · 0 stable samples ❌ Failed · 0 stable samples
Containers 0 observed 0 observed
Stabilization 0s 0s
Log collection ❌ Failed · 0 containers ❌ Failed · 0 containers

Hard-check reasons

  • Baseline: baseline_containers_unstable
  • Candidate: candidate_containers_unstable

Container comparison

  • Added: none
  • Removed: none
  • Baseline inventory: none
  • Candidate inventory: none
  • Baseline non-running states: none
  • Candidate non-running states: none
  • Deterministic regressions: ✅ none
Container inventory

Baseline

No container snapshot was available.

Candidate

No container snapshot was available.

Runtime analysis advisory

⚪ Inconclusive — Log analysis was unavailable

Analyzer Status Summary
Heuristic ⚪ Inconclusive Log analysis was unavailable
Baseline evidence ⚪ Inconclusive Analysis unavailable
Candidate evidence ⚪ Inconclusive Analysis unavailable

✅ No new runtime findings were reported.

Analyzer diagnostics
  • run ended before comparative log analysis

Cleanup and diagnostics

Check Result
Cleanup ⏭️ Skipped
Leftover packages none
Cleanup error none
Phase Code Message
Baseline preview baseline_unavailable MCP tool 'dappnode_fetch_install_preview' failed: Error: MultiUrlJsonRpcProvider: all RPC endpoints failed for method "eth_call". Last errors: - http://beacon-chain.mainnet.dncore.dappnode:3500: TypeError: fetch failed - https://web3.dappnode.net: Error: execution reverted (unknown custom error) (action="call", data="0x5fe9a5df0000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000001a0770692d686f6c6503646e700864…[truncated]

Deterministic checks decide the verdict. Runtime log analysis is advisory. TropiBot publishes bounded summaries and never posts raw logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant