Skip to content

fix: use build argument mappings (SPEC-C05) - #20

Merged
3alpha merged 1 commit into
mainfrom
fix/spec-c05-build-args
Nov 9, 2026
Merged

3alpha merged 1 commit into
mainfrom
fix/spec-c05-build-args

Conversation

@3alpha

@3alpha 3alpha commented Nov 9, 2026

Copy link
Copy Markdown
Member

Context

Correct SPEC-C05 from the package specification checks.

Based on the default branch main.

Approach

Replace list-style build arguments with a mapping while preserving every argument name and exact string value. Core package container names remain unchanged.

Test instructions

Run the SDK package-spec validation on this branch for all package variants.

Verified locally:

  • SDK loading and manifest/optional-asset schemas pass for all 1 variant.
  • Release-file generation, avatar verification and docker compose config --quiet pass for every variant.
  • Compared effective service settings, image/version pins and package identities with the parent: preserved.
  • git diff --check and replay of the complete PR stack pass.
  • SPEC-C05 findings in this layer: 1 → 0.

Full container images were not built locally.

@tropibot

tropibot Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 535ab57

This is a development version and should only be installed for testing purposes.

  1. Package portainer.dnp.dappnode.eth

Install link

Hash: /ipfs/QmYaRAbUCjCF3nqujE2ips9shL4RdXVG3VkP3gxGgrz1GC

(by dappnodebot/build-action)

@3alpha
3alpha merged commit 0479382 into main Nov 9, 2026
3 checks passed
@3alpha
3alpha deleted the fix/spec-c05-build-args branch November 9, 2026 12:09
@tropibot

tropibot Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✅ Package harness passed

Baseline and candidate containers became stably running

Package Verdict Reason Duration Cleanup
portainer.dnp.dappnode.eth ✅ Passed Candidate containers stable (candidate_containers_stable) 2m 32s ✅ Passed

Run overview

Context Value
Pull request dappnode/DAppNodePackage-portainer#20
Tested commit 535ab57c69b9
Candidate artifact Install on DAppNode · /ipfs/QmYaRAbUCjCF3nqujE2ips9shL4RdXVG3VkP3gxGgrz1GC
Baseline request automatic
Worker dappnode-near-5
Run ID gh-pr-20-535ab57c69b9-446a9c9367f15ca7
Execution 2026-11-09T12:38:26.293982492+00:00 → 2026-11-09T12:40:58.481350678+00:00 (✅ Completed)

Baseline vs candidate

Check Baseline Candidate
Version 0.1.0 0.1.1
Install ✅ Passed · 20s ✅ Passed · 1m 37s
Hard check ✅ Passed · 3 stable samples ✅ Passed · 3 stable samples
Containers 1 observed 1 observed
Stabilization 10s 10s
Log collection ✅ Passed · 1 container ✅ Passed · 1 container

Container comparison

  • Added: none
  • Removed: none
  • Baseline inventory: DAppNodePackage-portainer.portainer.dnp.dappnode.eth
  • Candidate inventory: DAppNodePackage-portainer.portainer.dnp.dappnode.eth
  • Baseline non-running states: none
  • Candidate non-running states: none
  • Deterministic regressions: ✅ none
Container inventory

Baseline

Container Service State Image Created
DAppNodePackage-portainer.portainer.dnp.dappnode.eth portainer ✅ Running portainer.portainer.dnp.dappnode.eth:0.1.0 1794227927

Candidate

Container Service State Image Created
DAppNodePackage-portainer.portainer.dnp.dappnode.eth portainer ✅ Running portainer.portainer.dnp.dappnode.eth:0.1.1 1794228038

Runtime analysis advisory

✅ Clean — Heuristic and Nexus analysis: No likely new runtime regressions are evident. The candidate completes database backup and migration, retains the pre-existing Chisel key, and starts Chisel plus HTTP/HTTPS listeners without errors or panics.

Analyzer Status Summary
Composite ✅ Clean Heuristic and Nexus analysis: No likely new runtime regressions are evident. The candidate completes database backup and migration, retains the pre-existing Chisel key, and starts Chisel plus HTTP/HTTPS listeners without errors or panics.
Heuristic ✅ Clean No configured candidate-only suspicious signature was found
Nexus ✅ Clean No likely new runtime regressions are evident. The candidate completes database backup and migration, retains the pre-existing Chisel key, and starts Chisel plus HTTP/HTTPS listeners without errors or panics.
Baseline evidence ✅ Clean No configured suspicious signature was found
Candidate evidence ✅ Clean No configured suspicious signature was found

✅ No new runtime findings were reported.

Cleanup and diagnostics

Check Result
Cleanup ✅ Passed
Leftover packages none
Cleanup error none

✅ No run errors were recorded.


Deterministic checks decide the verdict. Runtime log analysis is advisory. TropiBot publishes bounded summaries and never posts raw logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant