Skip to content

fix: migrate legacy upstream metadata (SPEC-M03) - #19

Open
3alpha wants to merge 1 commit into
masterfrom
fix/spec-m03-upstream-metadata
Open

3alpha wants to merge 1 commit into
masterfrom
fix/spec-m03-upstream-metadata

Conversation

@3alpha

@3alpha 3alpha commented Nov 9, 2026

Copy link
Copy Markdown
Member

Context

Fix the SPEC-M03 warning reported by the package specification checks. The legacy upstreamRepo, upstreamVersion and upstreamArg fields are deprecated.

Approach

Replace the legacy fields with upstream: [{ repo, version, arg }]: vipnode/vipnode, v2.2.1, UPSTREAM_VERSION.

Recover vipnode/vipnode from the checkout URL and expose the existing v2.2.1 pin as UPSTREAM_VERSION. The manifest includes the tag prefix already used by the checkout; the Dockerfile keeps its existing VERSION environment value and default.

Test instructions

Validate this branch with the SDK package-spec checker from the linked PR and confirm that no SPEC-M03 findings remain.

Verified locally:

  • Loaded 1 package using the SDK, including merged variant manifests where present.
  • SPEC-M03 findings: 1 → 0; total spec findings: 2 → 1; no new findings under other rules.
  • Compared manifest schemas and effective compose against the default branch: no new schema failures or service runtime changes.
  • git diff --check passes.
  • docker compose config --quiet passes.

Container images were not built locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant