@@ -7,7 +7,10 @@ import Listr from "listr";
77import { fetchPinsWithBranchToDelete } from "../src/pinStrategy/index.js" ;
88import { PinataPinManager } from "../src/providers/pinata/pinManager.js" ;
99import { Github } from "../src/providers/github/Github.js" ;
10- import { cleanPinsFromDeletedBranches } from "../src/commands/githubActions/build/cleanPinsFromDeletedBranches.js" ;
10+ import {
11+ cleanPinsFromDeletedBranches ,
12+ getPackageManifestsToClean
13+ } from "../src/commands/githubActions/build/cleanPinsFromDeletedBranches.js" ;
1114import { getDeleteOldPinsTask } from "../src/tasks/buildAndUpload/getDeleteOldPinsTask.js" ;
1215import {
1316 executable ,
@@ -164,3 +167,93 @@ describe("old pin cleanup on shallow CI checkouts", function () {
164167 expect ( pins . map ( pin => pin . commit ) ) . to . deep . equal ( commits . slice ( 0 , 2 ) ) ;
165168 } ) ;
166169} ) ;
170+
171+ describe ( "branch pin cleanup for template packages" , ( ) => {
172+ let dir : string ;
173+ const write = ( rel : string , data : object ) => {
174+ fs . mkdirSync ( path . dirname ( path . join ( dir , rel ) ) , { recursive : true } ) ;
175+ fs . writeFileSync ( path . join ( dir , rel ) , JSON . stringify ( data ) ) ;
176+ } ;
177+ beforeEach ( ( ) => {
178+ dir = temporaryDirectory ( ) ;
179+ // Same shape as DAppNodePackage-juno-generic: a named root, a variant that
180+ // inherits the name and one that overrides it.
181+ write ( "dappnode_package.json" , { name : "juno.dnp.dappnode.eth" } ) ;
182+ write ( "package_variants/mainnet/dappnode_package.json" , {
183+ name : "juno.dnp.dappnode.eth" ,
184+ version : "0.1.0"
185+ } ) ;
186+ write ( "package_variants/sepolia/dappnode_package.json" , {
187+ name : "juno-sepolia.dnp.dappnode.eth" ,
188+ version : "0.1.0"
189+ } ) ;
190+ } ) ;
191+ afterEach ( ( ) => {
192+ mock . restoreAll ( ) ;
193+ fs . rmSync ( dir , { recursive : true , force : true } ) ;
194+ } ) ;
195+
196+ it ( "finds variant package names even when the root manifest has a name" , ( ) => {
197+ expect (
198+ getPackageManifestsToClean ( { dir } ) . map ( manifest => manifest . name )
199+ ) . to . deep . equal ( [ "juno.dnp.dappnode.eth" , "juno-sepolia.dnp.dappnode.eth" ] ) ;
200+ } ) ;
201+
202+ it ( "uses only variant names when the root manifest has none" , ( ) => {
203+ write ( "dappnode_package.json" , { upstreamRepo : "x/y" } ) ;
204+ expect (
205+ getPackageManifestsToClean ( { dir } ) . map ( manifest => manifest . name )
206+ ) . to . deep . equal ( [ "juno.dnp.dappnode.eth" , "juno-sepolia.dnp.dappnode.eth" ] ) ;
207+ } ) ;
208+
209+ it ( "unpins deleted-branch pins of every variant package" , async ( ) => {
210+ const original = {
211+ key : process . env . PINATA_API_KEY ,
212+ secret : process . env . PINATA_SECRET_API_KEY
213+ } ;
214+ process . env . PINATA_API_KEY = "fake" ;
215+ process . env . PINATA_SECRET_API_KEY = "fake" ;
216+ mock . method ( Github , "fromLocal" , ( ) => ( {
217+ listBranches : async ( ) => [ { name : "main" } ] ,
218+ branchExists : async ( branch : string ) => branch === "main"
219+ } ) ) ;
220+ const queried : string [ ] = [ ] ;
221+ mock . method (
222+ PinataPinManager . prototype ,
223+ "pinList" ,
224+ async ( filters : { keyvalues : { dnpName : { value : string } } } ) => {
225+ const dnpName = filters . keyvalues . dnpName . value ;
226+ queried . push ( dnpName ) ;
227+ return [
228+ {
229+ ipfs_pin_hash : `${ dnpName } -deleted` ,
230+ metadata : {
231+ keyvalues : { dnpName, branch : "deleted" , commit : "1111111" }
232+ }
233+ }
234+ ] ;
235+ }
236+ ) ;
237+ const removed : string [ ] = [ ] ;
238+ mock . method ( PinataPinManager . prototype , "unpin" , async ( hash : string ) => {
239+ removed . push ( hash ) ;
240+ } ) ;
241+ try {
242+ await cleanPinsFromDeletedBranches ( { dir } ) ;
243+ } finally {
244+ if ( original . key === undefined ) delete process . env . PINATA_API_KEY ;
245+ else process . env . PINATA_API_KEY = original . key ;
246+ if ( original . secret === undefined )
247+ delete process . env . PINATA_SECRET_API_KEY ;
248+ else process . env . PINATA_SECRET_API_KEY = original . secret ;
249+ }
250+ expect ( queried ) . to . deep . equal ( [
251+ "juno.dnp.dappnode.eth" ,
252+ "juno-sepolia.dnp.dappnode.eth"
253+ ] ) ;
254+ expect ( removed ) . to . deep . equal ( [
255+ "juno.dnp.dappnode.eth-deleted" ,
256+ "juno-sepolia.dnp.dappnode.eth-deleted"
257+ ] ) ;
258+ } ) ;
259+ } ) ;
0 commit comments