Repository navigation
Conversation
bump-upstream assumed an existing bump branch already had a PR, so a branch whose PR creation was refused (e.g. GitHub Actions not allowed to create pull requests) made every later run skip that release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump-upstreamassumes an existing bump branch already has a PR. When the token isn't allowed to create pull requests, the branch gets pushed, PR creation fails, and every later run logsBranch ... already existsand passes. That's how https://github.com/xAlisher/logos-node-dappnode stayed on 0.3.1 while 0.3.2 and 0.3.4 shipped (https://github.com/xAlisher/logos-node-dappnode/actions/runs/41197630281).Now a bump branch that exists on the remote with no PR in any state gets its PR opened. A branch whose PR was closed is still skipped, closing it was a decision.