Skip to content

Commit 7ebd2ae

Browse files
authored
cleanup: pre-release sweep (#684)
grab-bag of fixes and formatting ahead of release
1 parent 6b2dd74 commit 7ebd2ae

176 files changed

Lines changed: 254 additions & 734 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/ISSUE_TEMPLATE/bug_report.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ body:
6060
description: What database backend are you using?
6161
options:
6262
- SQLite
63-
- MySQL
6463
- PostgreSQL
6564
validations:
6665
required: true

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ check-go:
1313
@which go > /dev/null || (echo "Go is not installed. Please install Go." && exit 1)
1414

1515
install-lint-deps:
16-
@which golangci-lint > /dev/null || (echo "Required golangci-lint not found. Installing it..." && go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest)
16+
@which golangci-lint > /dev/null || (echo "Required golangci-lint not found. Installing it..." && go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest)
1717
@which staticcheck > /dev/null || (echo "Required staticcheck not found. Installing it..." && go install honnef.co/go/tools/cmd/staticcheck@latest)
1818

1919
install-test-deps:

‎analytics/analytics.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ var logger = log.Logger("analytics")
2727

2828
// Init initializes the global variables 'Instance' and 'Enabled' based on values stored in the database
2929
// and environment variables respectively. The function uses the 'instance_id' key to fetch the 'Instance'
30-
// value from the database. If the 'Instance' value is already set, the function returns early. If the environment
31-
// variable 'SINGULARITY_ANALYTICS' is set to "0", 'Enabled' is set to false.
30+
// value from the database. If the 'Instance' value is already set, the function returns early. Analytics are
31+
// opt-in: unless the environment variable 'SINGULARITY_ANALYTICS' is set to "1", 'Enabled' is set to false.
3232
//
3333
// Parameters:
3434
// - ctx: The context for managing timeouts and cancellation.

‎api/api.go‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -404,14 +404,9 @@ var logger = logging.Logger("api")
404404
//
405405
// Parameters:
406406
// - ctx: A context.Context used to control the server's lifecycle and propagate cancellation.
407+
// - exitErr: A channel that receives the terminal error (or nil) once the server has shut down.
407408
//
408409
// Returns:
409-
// - A slice of channels (service.Done) that signal when different parts of the service
410-
// have completed their work. This includes:
411-
// 1. The main echo server's completion.
412-
// 2. The host's completion.
413-
// 3. Completion of analytics event flushing.
414-
// - A channel (service.Fail) that reports errors that occur while the server is running.
415410
// - An error if there is an issue during the initialization phase, otherwise nil.
416411
func (s *Server) Start(ctx context.Context, exitErr chan<- error) error {
417412
err := analytics.Init(ctx, s.db)

‎client/swagger/http/wallet_association/wallet_association_client.go‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎client/swagger/models/dataprep_create_request.go‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎client/swagger/models/deal_proposal.go‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎client/swagger/models/schedule_create_request.go‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎client/swagger/models/schedule_update_request.go‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎cmd/admin/init.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ var InitCmd = &cli.Command{
1717
Usage: "Name of the user or service that is running the Singularity for tracking and logging purpose",
1818
},
1919
},
20-
Description: "This commands need to be run before running any singularity daemon or after any version upgrade",
20+
Description: "This command needs to be run before running any singularity daemon or after any version upgrade",
2121
Action: func(c *cli.Context) error {
2222
db, closer, err := database.OpenFromCLI(c)
2323
if err != nil {

0 commit comments

Comments
 (0)