Repository navigation
Commit 663e1f7
pr-review skill: ask whether API changes were run on a real workspace (#7386)
## Changes
Adds one bullet to pass 9 (Tests) of
`.agents/skills/pr-review/SKILL.md`, placed after the bullet on whether
each new or changed test shows the effect it claims. When a change sends
a new field, value format or API call, and no covering test is `Cloud =
true` and the description does not mention a real-workspace run, the
review asks whether it was verified against one. Nothing else in the
skill changes. No `.nextchanges/` fragment is added, matching #7344,
which added the skill.
## Why
The fake server in `libs/testserver` only returns what its handlers were
taught. A test that records the request, or a handler that echoes a
field back, shows what the CLI sends, not what the API accepts. Pass 9
never asked whether such a change had been checked against a real
workspace, and maintainers ask that question often.
The gap showed up in a review of #7184 ("Support file selectors in
pipelines run"). The change started sending new
`refresh_selection_by_path` values (workspace paths, notebook extension
stripped) to the pipelines StartUpdate API. The only coverage was the
fake server echoing them back. The test was not `Cloud = true`, and the
PR description said no live-workspace run was done. The first review
question was whether it had been run against a real workspace, and the
skill as written would not have raised it.
The bullet asks a question rather than requiring a cloud run. Every
acceptance test still runs locally, and `Cloud = true` only adds a run
against a real workspace.
## Tests
- Markdown-only change. No Go code or acceptance tests changed.
- Ran the whitespace validator that `./task ws` runs, without `--fix`:
10787 checked, 0 failed.
- Checked the bullet's claims against `.agents/rules/testing.md`: `Cloud
= true` adds a cloud run and never removes the local one, `Cloud` is
inherited (so `out.test.toml` holds the effective value), and the fake
server lives in `libs/testserver`.
This pull request and its description were written by Isaac.
Co-authored-by: Isaac <no-reply@databricks.com>1 parent 119ba53 commit 663e1f7
1 file changed
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
142 | 150 | | |
143 | 151 | | |
144 | 152 | | |
| |||
0 commit comments