Skip to content

Commit 83f5df9

Browse files
[Trivial] clarify strict-mode warning error wording (#6916)
## Changes Clarify that `bundle validate --strict` treats warnings as errors. Update the acceptance snapshots. ## Why Matches the existing `--strict` help and [Clang's wording](https://clang.llvm.org/docs/UsersManual.html#clang-cl) for the same behavior. ## Tests Targeted acceptance cases, `./task checks`, and CI pass. _This PR was written by Codex._
1 parent 034a9c6 commit 83f5df9

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎acceptance/bundle/validate/secret_scope_invalid_permission_level/output.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ Workspace:
2828
Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default
2929

3030
Found 2 warnings
31-
Error: 2 warnings were found. Warnings are not allowed in strict mode
31+
Error: 2 warnings were found. Warnings are treated as errors in strict mode

‎acceptance/bundle/validate/strict/output.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Workspace:
2424
Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/foo
2525

2626
Found 1 warning
27-
Error: 1 warning was found. Warnings are not allowed in strict mode
27+
Error: 1 warning was found. Warnings are treated as errors in strict mode
2828

2929
Exit code: 1
3030

@@ -44,6 +44,6 @@ Workspace:
4444
Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/bar
4545

4646
Found 2 warnings
47-
Error: 2 warnings were found. Warnings are not allowed in strict mode
47+
Error: 2 warnings were found. Warnings are treated as errors in strict mode
4848

4949
Exit code: 1

‎cmd/bundle/validate.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ Please run this command before deploying to ensure configuration quality.`,
9797
} else {
9898
prefix = fmt.Sprintf("%d warnings were found", numWarnings)
9999
}
100-
return fmt.Errorf("%s. Warnings are not allowed in strict mode", prefix)
100+
return fmt.Errorf("%s. Warnings are treated as errors in strict mode", prefix)
101101
}
102102

103103
return err

0 commit comments

Comments
 (0)