Skip to content

Commit ae8800b

Browse files
committed
Keep pipeline test server changes focused on refresh selectors
1 parent 8af5260 commit ae8800b

2 files changed

Lines changed: 7 additions & 26 deletions

File tree

‎libs/testserver/pipelines.go‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,6 @@ func (s *FakeWorkspace) PipelineStartUpdate(req Request, pipelineId string) Resp
172172
FullRefreshSelection: start.FullRefreshSelection,
173173
RefreshSelectionByPath: start.RefreshSelectionByPath,
174174
FullRefreshSelectionByPath: start.FullRefreshSelectionByPath,
175-
ValidateOnly: start.ValidateOnly,
176175
}
177176

178177
return Response{

‎libs/testserver/pipelines_test.go‎

Lines changed: 7 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -95,37 +95,19 @@ func TestPipelineGetUpdatePreservesRefreshSelections(t *testing.T) {
9595
want pipelines.UpdateInfo
9696
}{
9797
{
98-
name: "refresh tables by source file",
99-
body: `{"refresh_selection_by_path":["/Workspace/src/orders.py","/Workspace/src/customers.sql"]}`,
100-
want: pipelines.UpdateInfo{RefreshSelectionByPath: []string{"/Workspace/src/orders.py", "/Workspace/src/customers.sql"}},
101-
},
102-
{
103-
name: "full refresh tables by source file",
104-
body: `{"full_refresh_selection_by_path":["/Workspace/src/orders.py"]}`,
105-
want: pipelines.UpdateInfo{FullRefreshSelectionByPath: []string{"/Workspace/src/orders.py"}},
106-
},
107-
{
108-
name: "independent file refresh modes",
109-
body: `{"refresh_selection_by_path":["/Workspace/src/orders.py"],"full_refresh_selection_by_path":["/Workspace/src/customers.sql"]}`,
110-
want: pipelines.UpdateInfo{
111-
RefreshSelectionByPath: []string{"/Workspace/src/orders.py"},
112-
FullRefreshSelectionByPath: []string{"/Workspace/src/customers.sql"},
113-
},
114-
},
115-
{
116-
name: "table refresh and file full refresh",
117-
body: `{"refresh_selection":["orders"],"full_refresh_selection_by_path":["/Workspace/src/customers.sql"]}`,
98+
name: "file selections",
99+
body: `{"refresh_selection_by_path":["/Workspace/src/orders.py","/Workspace/src/returns.py"],"full_refresh_selection_by_path":["/Workspace/src/customers.sql"]}`,
118100
want: pipelines.UpdateInfo{
119-
RefreshSelection: []string{"orders"},
101+
RefreshSelectionByPath: []string{"/Workspace/src/orders.py", "/Workspace/src/returns.py"},
120102
FullRefreshSelectionByPath: []string{"/Workspace/src/customers.sql"},
121103
},
122104
},
123105
{
124-
name: "file refresh and table full refresh",
125-
body: `{"refresh_selection_by_path":["/Workspace/src/orders.py"],"full_refresh_selection":["customers"]}`,
106+
name: "table selections",
107+
body: `{"refresh_selection":["orders"],"full_refresh_selection":["customers"]}`,
126108
want: pipelines.UpdateInfo{
127-
RefreshSelectionByPath: []string{"/Workspace/src/orders.py"},
128-
FullRefreshSelection: []string{"customers"},
109+
RefreshSelection: []string{"orders"},
110+
FullRefreshSelection: []string{"customers"},
129111
},
130112
},
131113
}

0 commit comments

Comments
 (0)