You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit df4dadd
Browse filesBrowse the repository at this point in the historyBrowse files
## Changes
`diag.Diagnostic.Paths` is `[]*structpath.PathNode` instead of
`[]dyn.Path`. Producers convert existing dyn paths with
`dyn.ToStructPaths` or build paths from keys with
`structpath.NewStringKeys`/`NewStringKeysSlice`/`MustParsePaths`.
`structpath.PureReferenceToPath` moves to
`dynvar.PureReferenceToStructPath` so structpath does not import dyn.
User-visible: diagnostic paths quote map keys that are not identifiers,
e.g. `resources.jobs['${var.env}_job']` instead of
`resources.jobs.${var.env}_job` (one golden).
## Why
First step of removing `libs/dyn` from bundle configuration: #6974 moves
`Location` to `libs/diag` on top of this (it needs diag to no longer
import dyn), then #6954.
This pull request and its description were written by Isaac.
---------
Co-authored-by: Isaac <no-reply@databricks.com>
* Diagnostic paths now quote map keys that are not identifiers, e.g. `resources.jobs['${var.env}_job']`. ([#6980](https://github.com/databricks/cli/pull/6980))
@@ -47,7 +48,7 @@ func (v *validate) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics
47
48
Severity: diag.Error,
48
49
Summary: "Duplicate app source code path",
49
50
Detail: fmt.Sprintf("app resource '%s' has the same source code path as app resource '%s', this will lead to the app configuration being overridden by each other", key, usedSourceCodePaths[app.SourceCodePath]),
Summary: fmt.Sprintf("app %q references %s %q which has permissions set. To prevent permission override after deploying the app, please add the app service principal to the %s permissions", appKey, refType, resourceKey, refType),
0 commit comments