You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e9e2d63
Browse filesBrowse the repository at this point in the historyBrowse files
structs: use only a struct's own ForceSendFields in structdiff and structwalk (#7224)
`structdiff` and `structwalk` looked up `ForceSendFields` with
`FieldByName`, which also finds one promoted from an embedded struct,
and used it for the outer struct's own fields. That list can only name
the embedded struct's fields (the SDK marshaller rejects other names),
so it was only ever applied by mistake: to an outer `omitempty` field
that shadows an embedded one. Both now look only at the struct that
declares the field, as `structaccess` and `libs/dyn/convert` already do.
No current type is affected: the shadowing fields are
`resources.ClusterPolicy` `definition` /
`policy_family_definition_overrides`, whose embedded list config loading
never fills with those names, and `QualityMonitor`/`QualityMonitorState`
`table_name`, which is not `omitempty`.
This pull request and its description were written by Isaac.
Co-authored-by: Isaac <no-reply@databricks.com>
0 commit comments