Repository navigation
Commit ea904f3
Upgrade go-runewidth to v0.0.31 to cut CLI startup time (#7391)
## Changes
Upgrade the indirect dependency `github.com/mattn/go-runewidth` from
v0.0.27 to v0.0.31.
v0.0.26 and v0.0.27 build a 2.2 MB rune-width lookup table in `init()`,
which adds ~30ms to every CLI invocation before any command runs.
v0.0.31 builds it lazily on first use.
## Tests
- `GODEBUG=inittrace=1`: runewidth init 30ms → 0.02ms.
- `databricks --version` median of 21 runs: 55.1ms → 22.3ms.
- Unit tests for all packages that depend on runewidth pass. The full
acceptance suite shows no differences from `main` locally.
This pull request and its description were written by Isaac.
---------
Co-authored-by: Isaac <no-reply@databricks.com>1 parent b61373f commit ea904f3
3 files changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
134 | | - | |
| 133 | + | |
| 134 | + | |
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| |||
0 commit comments