Skip to content

Commit fb3653c

Browse files
denikIsaac
andcommitted
Port the job environment_variables files pattern (#6985) to structpath
Co-authored-by: Isaac <no-reply@databricks.com>
1 parent 6752d92 commit fb3653c

2 files changed

Lines changed: 5 additions & 14 deletions

File tree

‎bundle/config/mutator/paths/job_paths_visitor.go‎

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,16 +67,7 @@ func jobRewritePatterns() []jobRewritePattern {
6767
patterns := append(taskPatterns, forEachPatterns...)
6868
return append(patterns,
6969
jobRewritePattern{
70-
dyn.NewPattern(
71-
dyn.Key("resources"),
72-
dyn.Key("jobs"),
73-
dyn.AnyKey(),
74-
dyn.Key("environment_variables"),
75-
dyn.AnyIndex(),
76-
dyn.Key("spec"),
77-
dyn.Key("files"),
78-
dyn.AnyIndex(),
79-
),
70+
structpath.MustParsePattern("resources.jobs.*.environment_variables[*].spec.files[*]"),
8071
TranslateModeFile,
8172
noSkipRewrite,
8273
},

‎bundle/config/mutator/paths/job_paths_visitor_test.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,10 @@ func TestVisitJobPaths_environmentVariables(t *testing.T) {
156156
}
157157

158158
actual := collectVisitedPaths(t, root, VisitJobPaths)
159-
expected := []dyn.Path{
160-
dyn.MustPathFromString("resources.jobs.job0.environment_variables[0].spec.files[0]"),
161-
dyn.MustPathFromString("resources.jobs.job0.environment_variables[0].spec.files[1]"),
162-
}
159+
expected := structpath.MustParsePaths(
160+
"resources.jobs.job0.environment_variables[0].spec.files[0]",
161+
"resources.jobs.job0.environment_variables[0].spec.files[1]",
162+
)
163163

164164
assert.ElementsMatch(t, expected, actual)
165165
}

0 commit comments

Comments
 (0)