Repository navigation
acceptance: add UniqueUUID test.toml knob for distinct UUID numbering - #7020
Merged
janniklasrose merged 1 commit intoNov 10, 2026
Conversation
janniklasrose
changed the title
denik
reviewed
Oct 12, 2026
| // UUID collapses to [UUID]. Enable it for tests that need to tell distinct UUIDs | ||
| // apart; leave it off when they appear in a non-deterministic order (the index | ||
| // assignment would be unstable). | ||
| UniqueUUID *bool |
Contributor
There was a problem hiding this comment.
Why do we need the option to switch it off? Why not always have uniqueness?
Member
Author
There was a problem hiding this comment.
Collaborator
✅ Integration test reportCommit: 5c0a683
Top 3 slowest tests (at least 2 minutes):
|
janniklasrose
force-pushed
the
janniklasrose/acc/uuid-unique-knob
branch
from
November 9, 2026 22:54
26ab8ff to
fc3f149
Compare
janniklasrose
changed the base branch from
main
to
janniklasrose/acc/distinct-single-value
November 9, 2026 22:55
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 6 not selected) 35 tests: regression=0 unreleased=0 coverage=35 failing=0
|
The built-in [UUID] replacement collapses every UUID to one token, so a golden cannot tell two distinct UUIDs apart (raised in review of #6995). Add a UniqueUUID test.toml knob (default false) that, when set, makes the built-in UUID replacement honor the existing Distinct numbering: distinct UUIDs in an output become [UUID][0], [UUID][1], ... in order of first appearance. Existing tests are unaffected (default off); a test opts in with UniqueUUID = true. Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
force-pushed
the
janniklasrose/acc/uuid-unique-knob
branch
from
November 9, 2026 23:30
fc3f149 to
5c0a683
Compare
janniklasrose
marked this pull request as ready for review
November 10, 2026 09:57
denik
approved these changes
Nov 10, 2026
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 11, 2026
## Changes Add numeric suffixes for `Distinct` replacements only when an output contains multiple distinct values. A repeated single value now stays unsuffixed: `[HASH][0]` becomes `[HASH]`. Includes the corresponding acceptance golden updates. ## Why Keep numbering focused on distinguishing different values. This is the generic prerequisite for the UUID numbering stack, followed by databricks#7020, databricks#7423, and databricks#7021. ## Tests Unit coverage checks single matches, repeated identical values, and multiple distinct values. Formatting, checks, lint, and the full test suite passed on the completed stack; databricks#7021 records the transient retry. _This change was split and validated with Codex._
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 11, 2026
…atabricks#7423) ## Changes Capture the immutable no-artifacts test's initial plan in a separate golden, preserving its assertions. Teach the Python replacement helper to honor `Distinct` so template comparisons can match numbered goldens. ## Why Saved-plan deployment reuses the planned snapshot UUID; direct deployment generates another. Separate plan output lets both variants share expectations. Template comparisons also need the same numbering behavior as the Go harness before databricks#7021 removes the UUID opt-out. Stacked on databricks#7020. UUID numbering remains off by default in this PR. ## Tests Both immutable variants, template tests, and helper selftests passed with numbering off. Python doctests cover repeated values, multiple distinct values, and already-normalized output. Formatting, checks, lint, and the full test suite passed with numbering always enabled on the completed stack; databricks#7021 records the transient retry. _This PR was written by Codex._
denik
added
the
test-only-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add opt-in UUID numbering through
UniqueUUID, defaulting tofalse, with unit tests and acceptance selftests. Existing goldens stay unchanged.Why
Keep the UUID replacement implementation separate from the golden updates. This is layer 2 after #7420: #7423 prepares affected tests, then #7021 removes the temporary option and enables numbering unconditionally.
Tests
go test ./libs/testdiff ./acceptance/internaland both UUID acceptance selftests passed on this layer.This PR was written by Isaac and revised with Codex.