Repository navigation
Conversation
The direct engine always sent user_api_scopes in the Apps update_mask, so any update (e.g. a description change) cleared scopes that cannot be set through this API, such as "jobs" added at the account level. Now user_api_scopes is only in the mask when the bundle changes it, and remote-only drift on it is ignored. The testserver now clears masked fields that are absent from the body, like the real API. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
|
Commit: Regression test reportSelected 5 changed tests (limit=20, 0 not selected) 10 tests: regression=8 unreleased=0 coverage=2 failing=0
TestAccept/bundle/resources/apps/lifecycle-started/DMS=: branch ✅ | main (8191901) ❌ | latest (v1.22.1) ❌main (8191901): latest (v1.22.1): same output as main (8191901) TestAccept/bundle/resources/apps/lifecycle-started/DMS=true: branch ✅ | main (8191901) ❌ | latest (v1.22.1) ❌main (8191901): latest (v1.22.1): same output as main (8191901) TestAccept/bundle/resources/apps/update-declared-scopes/DMS=: branch ✅ | main (8191901) ❌ | latest (v1.22.1) ❌main (8191901): latest (v1.22.1): same output as main (8191901) TestAccept/bundle/resources/apps/update-declared-scopes/DMS=true: branch ✅ | main (8191901) ❌ | latest (v1.22.1) ❌main (8191901): latest (v1.22.1): same output as main (8191901) TestAccept/bundle/resources/apps/update-omitted-scopes/DMS=: branch ✅ | main (8191901) ❌ | latest (v1.22.1) ❌main (8191901): latest (v1.22.1): same output as main (8191901) TestAccept/bundle/resources/apps/update-omitted-scopes/DMS=true: branch ✅ | main (8191901) ❌ | latest (v1.22.1) ❌main (8191901): latest (v1.22.1): same output as main (8191901) TestAccept/bundle/resources/apps/update/DMS=: branch ✅ | main (8191901) ❌ | latest (v1.22.1) ❌main (8191901): latest (v1.22.1): same output as main (8191901) TestAccept/bundle/resources/apps/update/DMS=true: branch ✅ | main (8191901) ❌ | latest (v1.22.1) ❌main (8191901): latest (v1.22.1): same output as main (8191901) |
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Integration test reportCommit: 95dcba4
Top 18 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
|
This PR has not received an update in a while. If you want to keep this PR open, please leave a comment below or push a new commit and auto-close will be canceled. |
Changes
user_api_scopesis only in the apps update mask when the bundle declares it (or removes it, which clears it). Out-of-band changes to it no longer plan an update.Why
Every apps update sent
user_api_scopesin the mask, so changing e.g. the description cleared scopes the bundle doesn't manage, likejobsadded at the account level. The update API can't setjobs(rejected as an invalid scope) but does clear the field, and the mask accepts only the whole field.Tests
New acceptance tests
update-declared-scopes,update-omitted-scopesandupdate-removed-scopes. The testserver now clears masked fields missing from the body, like the real API.This pull request and its description were written by Isaac.