Repository navigation
Conversation
files/v2 calls are not retried without a per-call retrier, so since #6018 a transient 503/429/502/504 from the Files API failed fs commands on UC Volumes outright. Retry reads, metadata checks, listing and mkdir; uploads and deletes are left alone. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: d0752f4
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Pass a retrier to the idempotent Files API calls in
libs/filer/files_client.go: file/directory metadata (Stat, the parent check inWrite),ReadDir,ReadandMkdir. Retried statuses are 408/429/502/503/504, the same list the files/v2 upload engine uses for its control-plane calls, with a 5 minute budget per call. Uploads (body can't be replayed) and deletes (a retry after a server-side success would turn into a 404) are unchanged.Why
files/v2 calls are not retried unless a retrier is passed per call. Since the filer moved to files/v2 in #6018, a transient error like
GCP is temporarily unavailable; try again later.fails the command immediately, where the old SDK client retried 429/503. This shows up as the GCP flakes ofintegration/cmd/fs.TestFsCpFileToNonExistentDir(CI dashboard error 3017).The status code of those GCP errors isn't in the CI logs;
TEMPORARILY_UNAVAILABLEis normally a 503. 500 is deliberately not retried, matching both SDKs.Tests
New unit tests: a 503 followed by success is retried, a 500 is not.
go test ./libs/filer/... ./cmd/fs/...and thecmd/fsacceptance tests pass.This pull request and its description were written by Isaac.