Repository navigation
Conversation
Locally the root dir id is 1000 + a counter, and the bare literal could match inside a timestamp, which then no longer matched [UNIX_TIME_NANOS]. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Collaborator
Integration test reportCommit: 9f38514
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Register the prod root directory id as
directories/<id>instead of the bare id.Why
Locally the testserver gives workspace nodes ids of 1000 + a counter, so the id is a 4-digit number. User replacements are applied before the harness's timestamp patterns, so when those 4 digits occurred inside a wheel's
+<nanos>version orcreated_time, the timestamp was cut up and no longer matched[UNIX_TIME_NANOS]/[UNIX_TIME_MILLIS]:Seen on macOS for
TestAccept/bundle/templates/default-python/classic/DMS=/READPLAN=1. Thebundle/dms/*tests register short deployment ids the same way, but their outputs have no timestamps, so they are not affected.Tests
Regenerated; the test passes locally.
This pull request and its description were written by Isaac.