Skip to content

testserver: use 16-digit workspace object ids to fix flaky id replacements #7253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

testserver: use 16-digit workspace object ids to fix flaky id replacements #7253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions libs/testserver/fake_workspace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,12 @@ var (
workspaceID atomic.Int64
)

// nextTreenodeID starts above common version numbers and counts, which scripts
// can otherwise mask when registering literal ID replacements.
// nextTreenodeID returns 16-digit ids, like real workspace object ids. Scripts register them as
// literal replacements, which apply before the harness's patterns; a short id would also match
// inside other numbers in the output (timestamps, UUIDs, ports) and cut them up. A 16-digit id
// starting with 4 practically never occurs inside those, and never looks like a timestamp.
func nextTreenodeID() int64 {
return 1000 + workspaceID.Add(1)
return 4_000_000_000_000_000 + workspaceID.Add(1)
}

// IDs are prefixed with 7 and padded to avoid matching regex 1[78]\d{14}
Expand Down
Loading