Skip to content

ssh: document --environment-version on ssh connect - #7264

Draft
anton-107 wants to merge 2 commits into
mainfrom
deco-28307-ssh-environment-version-flag
Draft

anton-107 wants to merge 2 commits into
mainfrom
deco-28307-ssh-environment-version-flag

Conversation

@anton-107

Copy link
Copy Markdown
Contributor

Changes

  • ssh connect --environment-version now shows in help, with a description that is no longer AI-Runtime-only, and with an example.
  • An explicit version is folded into the default connection name, as --base-environment already is. So ssh connect followed by ssh connect --environment-version 5 starts a v5 server instead of reusing the running v4 one. Default names without the flag are unchanged.
  • The flag is rejected together with --cluster, matching --base-environment and --usage-policy-id.

Why

CPU serverless environments 5 and 6 now work with the tunnel wherever the REPL sandbox's port forwarding is enabled. That covers SDP stages up to 3am as of 2026-10-29, and I verified it on prod AWS us-west-2 (DECO-28307). Users need a supported opt-in before the default moves off 4 once the rollout finishes. The IDE path already picks up the flag: ssh connect --ide vscode --environment-version 5 carries it in the generated ProxyCommand. ssh setup is dedicated-only, so it gets no flag.

Before this change the flag was hidden and ignored with --cluster, so rejecting that pair can only affect a hand-written invocation that never had any effect.

Tests

  • Unit tests cover the new validation and the connection-name hashing (including no collision with a base environment named 5).
  • go test ./acceptance -run TestAccept/ssh passes.
  • With a local build I checked the --help output and the --cluster rejection.

This pull request and its description were written by Isaac.

anton-107 and others added 2 commits October 30, 2026 15:35
Serverless environment versions 5 and 6 now work with the tunnel in the
regions where the driver's sandbox port forwarding is enabled, so users
need a supported way to opt in before the default moves off 4.

Make the flag visible, and close the two gaps a public flag would expose:

- Fold an explicit version into the default connection name, the same
  way --base-environment already is. Otherwise `ssh connect` followed by
  `ssh connect --environment-version 5` reuses the running version 4
  server.
- Reject the flag together with --cluster instead of silently ignoring it,
  matching --base-environment and --usage-policy-id.

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 8c90804

Run: 41083993254

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 281 15 6:00
✅​ aws-windows-latest-4core-16gb 283 13 4:31
✅​ azure linux-2core-8gb 280 15 4:55
✅​ azure-windows-latest-4core-16gb 282 13 4:08
✅​ gcp linux-2core-8gb 281 15 5:28
✅​ gcp-windows-latest-4core-16gb 283 13 4:19
Top 6 slowest tests (at least 2 minutes):
duration env testname
4:26 aws-windows-latest-4core-16gb TestAccept
4:14 gcp-windows-latest-4core-16gb TestAccept
4:03 azure-windows-latest-4core-16gb TestAccept
3:48 aws linux-2core-8gb TestAccept
3:44 gcp linux-2core-8gb TestAccept
2:58 azure linux-2core-8gb TestAccept

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants