Repository navigation
air: don't announce retries before a run fails - #7270
Merged
Merged
Conversation
`air run --watch` printed "Failed attempts will be retried up to 3 times." on every run, because max_retries defaults to 3. On a healthy run this reads as if something already failed. The log stream already prints "Retrying (n of m)..." when a retry actually happens. Tracking: CNXT-2481. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: eebc79e
Top 6 slowest tests (at least 2 minutes):
|
caroline-db
approved these changes
Oct 30, 2026
Collaborator
Integration test reportCommit: eb72905
9 interesting tests: 9 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove the "Failed attempts will be retried up to N times." line that
databricks air run --watchprints between "Monitoring run and streaming logs..." and the logs divider. A retry is still reported when it actually happens (Retrying (1 of 3)...), so no information is lost.Why
max_retriesdefaults to 3, so every watched run printed this line before any logs streamed. On a healthy run it reads as if an attempt had already failed, which users reported as a papercut.Tests
TestRunWatchStreamsLogsnow asserts that a successful watched run never mentions retries. The existinglogstream_test.gocoverage ofRetrying (1 of 3)...on a real retry is unchanged.cmd/airunit tests and theTestAccept/air/acceptance tests pass locally; golangci-lint oncmd/airreports no issues.This pull request and its description were written by Isaac.