Repository navigation
[FS-2621] Enable DMS for Feature and MaterializationSet in DAB - #7369
Open
Daniel114510 wants to merge 5 commits into
Open
Daniel114510 wants to merge 5 commits into
Daniel114510 wants to merge 5 commits into
Conversation
…tion sets The deployment metadata service is gaining the features. and materialization_sets. resource-key prefixes, so the test server's allowlist adds both, and the exclusions that kept these cases off the DMS=true leg are removed. Every case produces the same goldens on both legs. bind and settled_failure stay pinned to the plain leg for their own reasons. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 13 changed tests (limit=20, 0 not selected) 26 tests: regression=0 unreleased=0 coverage=26 failing=0
|
Daniel114510
changed the title
Collaborator
✅ Integration test reportCommit: 28ef7d0
9 interesting tests: 9 flaky
Top 42 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
…tset # Conflicts: # acceptance/bundle/invariant/test.toml
Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
approved these changes
Nov 11, 2026
janniklasrose
left a comment
janniklasrose
left a comment
Member
There was a problem hiding this comment.
approving but this can only merge once the backend changes have propagated and the test suite is green
denik
added
the
test-only-fix
…tset Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
featuresandmaterialization_setsprefixes to the test server's deployment history allowlist,dmsResourceTypes.DMS=trueleg.materialization_sets/bindandmaterialization_sets/settled_failurestay on the plain leg: bind refuses to run while deployment history is recorded, and with it recorded the destroy insettled_failurereturns the delete error instead of forgiving it.Why
The deployment metadata service is adding both resource-key prefixes, so a deploy that records deployment history will no longer fail for a bundle with a feature or materialization set.
Tests
bundle/resources/features,bundle/resources/materialization_sets: both legs match one set of goldensbundle/invariant: the feature config runs on theDMS=truelegDMS=trueruns: pending the service deploy