Repository navigation
Rename registered models in place and follow parent renames #7379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+2,359
−157
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
f6a34fd
acc: a model and a secret named after a renamed schema are deleted at…
denik 97551c4
direct: only the fields naming a UC resource's parent follow the pare…
denik dd3927f
Add changelog fragment for the parent ID fields fix
denik 97cbfc5
Rename registered models in place and follow parent renames
denik 074dd7d
Link PR in changelog fragment
denik 4ca7e29
direct: read a moved model's aliases when the plan could not
denik b18917f
Drop the alias read for a model the plan could not read; delete model…
denik c42e331
acc: show the skipped schema_id change in the model rename plans
denik 56fd46f
Point comment at followsParentRename
denik 74f17af
direct: let the framework re-key a model that only follows its parent…
denik 65278bf
direct: never send a model's name with new_name
denik 603c7f0
acc: also deploy registered_models/rename from a saved plan (READPLAN)
denik b87e94f
Make the changelog entry mirror the PR title
denik 60633a8
acc: the model follows the schema's rename in rename_with_model_and_s…
denik 15f209d
acc: regenerate the registered model goldens after rebase
denik dc2dcd3
testserver: report a missing registered model with UC's message
denik 638cb08
acc: a registered model follows a catalog rename in catalogs/rename
denik c51b8bb
acc: a registered model follows its catalog and schema renamed in one…
denik 8fbc9c9
acc: update, rename and recreate a registered model after its schema …
denik 5694294
acc: a registered model moved out of a renamed schema is deleted wher…
denik c20dd17
acc: a job reading a registered model's full_name and id follows its …
denik c3999e6
acc: grants follow a registered model's in-place rename
denik 01f3424
acc: keep volumes/rename_catalog_and_schema about volumes; the model …
denik 9e352d0
acc: keep volumes/move_from_renamed_schema about volumes; the model c…
denik 24efc32
acc: keep schemas/rename_with_volume_ref about the volume
denik bd02d89
acc: keep grants/volume_change_name about the volume; the model case …
denik 498c874
acc: a registered model follows its catalog and schema renamed in one…
denik e743974
acc: a registered model moved out of a renamed schema is deleted wher…
denik 20f9942
acc: grants follow a registered model's in-place rename
denik 8702f6f
acc: trim registered_models/rename to the model's own rename
denik c2a2e5c
testserver: reject creating a registered model that already exists, a…
denik 6930f24
acc: a model whose schema is renamed out of band is created again (Ba…
denik 9f2dabe
acc: a model whose schema rename is interrupted is created again (Bad…
denik d1a2a06
testserver: reject renaming a registered model onto a taken name, as …
denik 4d735dc
acc: renaming a registered model onto a taken name fails and keeps bo…
denik 0f39e2a
direct: sync a model's aliases before renaming it (review R1)
denik 906fddd
direct: take a renamed model's ID from the response, like create does…
denik 61c8eb6
direct: record the ID a parent's rename moved a resource to before up…
denik 80db03d
acc: a renamed model keeps its versions, and a failed alias leaves it…
denik eb9e85c
acc: an interrupted schema rename now updates the volume at its recor…
denik a6cd20d
acc: a model named after a renamed schema is renamed in place
denik b2c3a1f
Group the deployplan import with the other bundle imports
denik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * Delete the old resource when its name follows a renamed schema. ([#7718](https://github.com/databricks/cli/pull/7718)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * Rename registered models in place and follow parent renames. ([#7379](https://github.com/databricks/cli/pull/7379)) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
acceptance/bundle/resources/grants/registered_model_change_name/databricks.yml.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| bundle: | ||
| name: test-bundle-$UNIQUE_NAME | ||
|
|
||
| resources: | ||
| schemas: | ||
| schema1: | ||
| catalog_name: main | ||
| name: test-schema-$UNIQUE_NAME | ||
| registered_models: | ||
| model1: | ||
| catalog_name: main | ||
| schema_name: ${resources.schemas.schema1.name} | ||
| name: mymodel | ||
| grants: | ||
| - principal: deco-test-user@databricks.com | ||
| privileges: | ||
| - APPLY_TAG |
2 changes: 2 additions & 0 deletions
2
acceptance/bundle/resources/grants/registered_model_change_name/out.test.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Cloud = true | ||
| EnvMatrix.DMS = ["", "true"] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[AI Generated] nit: "Follow parent renames" is an internal term. Could this say what users see, as schema-rename.md does: a model in a renamed catalog or schema is no longer recreated and keeps its versions?