Repository navigation
Move cluster policy matcher and loader to libs/clusterpolicy - #7409
Merged
Merged
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 0b09b08
Top 3 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Nov 9, 2026
pietern
left a comment
pietern
left a comment
Contributor
There was a problem hiding this comment.
You mention the testserver, but it doesn't yet use this lib.
Is there opportunity to do so and reduce custom code in the testserver?
Contributor
Author
I think the PR description sounds more ambitious than this PR has to offer 🙂 I'll update the description I checked what else can be reused, not too much, as remaining policy helpers are spec-to-policy (spec is cluster config, policy is the set of spec attributes), and the testserver is mostly interested in policy-to-spec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #7170. The parts of the cluster policy handling that encode the policy definition language move from
bundle/configsyncintolibs/clusterpolicy:Definition.IsPolicyValue(path, value, applyDefaults): whether the value of a cluster attribute comes from the policy (fixed rules, opted-in defaults, indexed-over-wildcard precedence, dotted map keys, log-delivery aliases).Loader/LookupError: reads effective definitions by ID overcompute.ClusterPoliciesInterfaceand caches definitions and failures for its lifetime.configsync keeps the sync-specific reconciliation (
filterChanges,prune, authored-vs-remote checks) and theSkippedChangemapping. No behavior change.Why
Other callers can rely on the shared matcher and loader instead of reimplementing policy semantics, and configsync no longer owns policy-language knowledge.
Tests
Moved code is covered by the existing configsync unit tests and the
config-remote-sync/resources/jobs/cluster_policyacceptance tests, which pass unchanged. Added unit tests forIsPolicyValue(rule precedence, map wildcard exclusion, aliases) andLoadercaching.This pull request and its description were written by Isaac.