Repository navigation
testdiff: leave repeated single values unnumbered - #7420
Merged
Merged
Conversation
This was referenced Nov 9, 2026
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 4 not selected) 36 tests: regression=0 unreleased=0 coverage=36 failing=0
|
Collaborator
✅ Integration test reportCommit: 3d50b7c
Top 3 slowest tests (at least 2 minutes):
|
janniklasrose
force-pushed
the
janniklasrose/acc/distinct-single-value
branch
from
November 9, 2026 23:30
4d2a3b5 to
3d50b7c
Compare
janniklasrose
marked this pull request as ready for review
November 10, 2026 09:57
denik
approved these changes
Nov 10, 2026
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 11, 2026
…databricks#7020) ## Changes Add opt-in UUID numbering through `UniqueUUID`, defaulting to `false`, with unit tests and acceptance selftests. Existing goldens stay unchanged. ## Why Keep the UUID replacement implementation separate from the golden updates. This is layer 2 after databricks#7420: databricks#7423 prepares affected tests, then databricks#7021 removes the temporary option and enables numbering unconditionally. ## Tests `go test ./libs/testdiff ./acceptance/internal` and both UUID acceptance selftests passed on this layer. _This PR was written by Isaac and revised with Codex._ Co-authored-by: Isaac <no-reply@databricks.com>
denik
added
the
test-only-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add numeric suffixes for
Distinctreplacements only when an output contains multiple distinct values. A repeated single value now stays unsuffixed:[HASH][0]becomes[HASH]. Includes the corresponding acceptance golden updates.Why
Keep numbering focused on distinguishing different values. This is the generic prerequisite for the UUID numbering stack, followed by #7020, #7423, and #7021.
Tests
Unit coverage checks single matches, repeated identical values, and multiple distinct values. Formatting, checks, lint, and the full test suite passed on the completed stack; #7021 records the transient retry.
This change was split and validated with Codex.