Repository navigation
acceptance: prepare plan and template comparisons for UUID numbering - #7423
Merged
Merged
Conversation
The built-in [UUID] replacement collapses every UUID to one token, so a golden cannot tell two distinct UUIDs apart (raised in review of #6995). Add a UniqueUUID test.toml knob (default false) that, when set, makes the built-in UUID replacement honor the existing Distinct numbering: distinct UUIDs in an output become [UUID][0], [UUID][1], ... in order of first appearance. Existing tests are unaffected (default off); a test opts in with UniqueUUID = true. Co-authored-by: Isaac <no-reply@databricks.com>
This was referenced Nov 9, 2026
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 7 not selected) 35 tests: regression=0 unreleased=0 coverage=35 failing=0
|
Collaborator
✅ Integration test reportCommit: d9d1f41
Top 3 slowest tests (at least 2 minutes):
|
denik
approved these changes
Nov 10, 2026
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 11, 2026
## Changes Add numeric suffixes for `Distinct` replacements only when an output contains multiple distinct values. A repeated single value now stays unsuffixed: `[HASH][0]` becomes `[HASH]`. Includes the corresponding acceptance golden updates. ## Why Keep numbering focused on distinguishing different values. This is the generic prerequisite for the UUID numbering stack, followed by databricks#7020, databricks#7423, and databricks#7021. ## Tests Unit coverage checks single matches, repeated identical values, and multiple distinct values. Formatting, checks, lint, and the full test suite passed on the completed stack; databricks#7021 records the transient retry. _This change was split and validated with Codex._
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 11, 2026
…databricks#7020) ## Changes Add opt-in UUID numbering through `UniqueUUID`, defaulting to `false`, with unit tests and acceptance selftests. Existing goldens stay unchanged. ## Why Keep the UUID replacement implementation separate from the golden updates. This is layer 2 after databricks#7420: databricks#7423 prepares affected tests, then databricks#7021 removes the temporary option and enables numbering unconditionally. ## Tests `go test ./libs/testdiff ./acceptance/internal` and both UUID acceptance selftests passed on this layer. _This PR was written by Isaac and revised with Codex._ Co-authored-by: Isaac <no-reply@databricks.com>
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 11, 2026
## Changes Remove the temporary `UniqueUUID` option and always distinguish UUIDs, updating acceptance goldens with numeric suffixes. In the materialization-set `batch` and `removal_scope` tests, register the deployed set ID as `[SET1_ID]` with `read_id.py` and remove the compact-UUID TOML replacements. This makes the dashed local IDs and compact cloud IDs use the same named replacement before request/operation UUIDs are numbered. ## Why Expected output should distinguish different UUIDs consistently. databricks#7423 handles the immutable and template comparisons. The materialization-set fix addresses the deterministic cloud mismatch found during the five sequential CI repetitions. ## Tests `./task fmt`, `./task checks`, `./task lint`, and the materialization-set acceptance tests passed. The full local suite was blocked by the unrelated completion-test SIGPIPE and temporary-home cleanup; `inittime` passed on retry. Cloud CI validation is pending. _This PR was written by Isaac and revised with Codex._
denik
added
the
test-only-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Capture the immutable no-artifacts test's initial plan in a separate golden, preserving its assertions. Teach the Python replacement helper to honor
Distinctso template comparisons can match numbered goldens.Why
Saved-plan deployment reuses the planned snapshot UUID; direct deployment generates another. Separate plan output lets both variants share expectations. Template comparisons also need the same numbering behavior as the Go harness before #7021 removes the UUID opt-out.
Stacked on #7020. UUID numbering remains off by default in this PR.
Tests
Both immutable variants, template tests, and helper selftests passed with numbering off. Python doctests cover repeated values, multiple distinct values, and already-normalized output. Formatting, checks, lint, and the full test suite passed with numbering always enabled on the completed stack; #7021 records the transient retry.
This PR was written by Codex.