Repository navigation
Translate the testing paths of pipelines and upload local test wheels - #7437
tharunbhuk-db wants to merge 1 commit into
Conversation
|
Commit: Regression test reportSelected 4 changed tests (limit=20, 0 not selected) 8 tests: regression=8 unreleased=0 coverage=0 failing=0
TestAccept/bundle/environments/dependencies/DMS=: branch ✅ | main (cec3f63) ❌ | latest (v1.26.0) ❌main (cec3f63): latest (v1.26.0): same output as main (cec3f63) TestAccept/bundle/environments/dependencies/DMS=true: branch ✅ | main (cec3f63) ❌ | latest (v1.26.0) ❌main (cec3f63): latest (v1.26.0): same output as main (cec3f63) TestAccept/bundle/refschema/DMS=: branch ✅ | main (cec3f63) ❌ | latest (v1.26.0) ❌main (cec3f63): latest (v1.26.0): TestAccept/bundle/refschema/DMS=true: branch ✅ | main (cec3f63) ❌ | latest (v1.26.0) ❌main (cec3f63): latest (v1.26.0): TestAccept/bundle/resources/pipelines/testing-same-name-libraries/DMS=: branch ✅ | main (cec3f63) ❌ | latest (v1.26.0) ❌main (cec3f63): latest (v1.26.0): TestAccept/bundle/resources/pipelines/testing-same-name-libraries/DMS=true: branch ✅ | main (cec3f63) ❌ | latest (v1.26.0) ❌main (cec3f63): latest (v1.26.0): TestAccept/bundle/resources/pipelines/testing/DMS=: branch ✅ | main (cec3f63) ❌ | latest (v1.26.0) ❌main (cec3f63): latest (v1.26.0): same output as main (cec3f63) TestAccept/bundle/resources/pipelines/testing/DMS=true: branch ✅ | main (cec3f63) ❌ | latest (v1.26.0) ❌main (cec3f63): latest (v1.26.0): same output as main (cec3f63) |
✅ Integration test reportCommit: 52dc912
Top 6 slowest tests (at least 2 minutes):
|
239501f to
bc013c0
Compare
48e4a95 to
fd9fedb
Compare
bc013c0 to
08916f8
Compare
fd9fedb to
b10a21e
Compare
08916f8 to
4c21f8b
Compare
b10a21e to
e5ff44c
Compare
| @@ -1,3 +1,4 @@ | |||
| title "Relative test paths resolve to the deployed workspace paths\n" | |||
| trace $CLI bundle validate -o json | jq .resources.pipelines.orders.testing | |||
There was a problem hiding this comment.
Could you add a bundle deploy here (RecordRequests is already on in test.toml) so we see the test wheel uploaded and ./dist/*.whl rewritten to its .internal path? This test only runs validate, so the wheel stays ./dist/*.whl in the output, and the same-name test fails before upload, so nothing in the goldens shows the upload the description talks about. If that has to wait for #7438, worth a note in the script.
| }, | ||
| // Test dependencies take the same forms as the pipeline's environment dependencies. | ||
| { | ||
| pattern: base.Append(dyn.Key("testing"), dyn.Key("environment"), dyn.Key("dependencies"), dyn.AnyIndex()), |
There was a problem hiding this comment.
nit: the four dependency entries now differ only in the path prefix. Maybe loop over the two locations (environment and testing.environment) so the modes and skip functions live in one place?
4c21f8b to
33085b7
Compare
e5ff44c to
858d4df
Compare
Relative paths in testing.sources and testing.environment.dependencies resolve to their deployed workspace paths, like libraries and environment dependencies. Local wheels in test dependencies are uploaded like other libraries, and the same-name check covers them. The testing property is only accepted with DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_PIPELINE_TESTING=true, so bundles without it are not changed. Co-authored-by: Isaac <no-reply@databricks.com>
33085b7 to
86997dc
Compare
858d4df to
52dc912
Compare
🥞 Stacked PR
testingresolve to their deployed paths, and local test wheels upload like other libraries.testingare affected.Tests: acceptance
bundle/resources/pipelines/testingandtesting-same-name-libraries.This pull request and its description were written by Isaac.