Skip to content

pr-review skill: list doc comments in Python, shell and YAML too - #7464

Merged
andrewnester merged 1 commit into
mainfrom
andrewnester/pr-review-skill-doc-comments
Nov 11, 2026
Merged

andrewnester merged 1 commit into
mainfrom
andrewnester/pr-review-skill-doc-comments

Conversation

@andrewnester

@andrewnester andrewnester commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Pass 8 lists doc comments for Python, shell and YAML too, counts acceptance/bin docstrings and test-function doc comments in test-only changes, and asks to check other callers when a new comment claims an API quirk.

Why

On YAML-, Python- and test-only PRs the Go-only grep left the table empty exactly where the comment was the point.

Tests

Docs only.

This pull request and its description were written by Isaac.

Pass 8 only grepped Go files, so for YAML, Python, script and test-only
changes the doc-comment table came up empty on exactly the changes where
the comment was the point. Also ask the reviewer to check other callers
when a new comment claims an API quirk.

Co-authored-by: Isaac <no-reply@databricks.com>
@andrewnester
andrewnester requested a review from a team as a code owner November 11, 2026 14:05
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: a3c480d

Run: 43035334124

Env 🔄​flaky ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 271 15 6:00
✅​ aws-windows-latest-4core-16gb 273 13 3:54
✅​ azure linux-2core-8gb 270 15 5:34
🔄​ azure-windows-latest-4core-16gb 4 268 13 4:26
🔄​ gcp linux-2core-8gb 2 269 15 6:26
✅​ gcp-windows-latest-4core-16gb 273 13 3:49
6 interesting tests: 6 flaky
Test Name azure-windows-latest-4core-16gb gcp linux-2core-8gb
🔄​ TestFsCpDirToDirFileNotOverwritten ✅​p 🔄​f
🔄​ TestFsCpDirToDirFileNotOverwritten/dbfs_to_uc-volumes ✅​p 🔄​f
🔄​ TestFsCpFileToDir 🔄​f ✅​p
🔄​ TestFsCpFileToDir/uc-volumes_to_dbfs 🔄​f ✅​p
🔄​ TestFsCpFileToFileWithOverwriteFlag 🔄​f ✅​p
🔄​ TestFsCpFileToFileWithOverwriteFlag/uc-volumes_to_uc-volumes 🔄​f ✅​p
Top 6 slowest tests (at least 2 minutes):
duration env testname
3:57 aws linux-2core-8gb TestAccept
3:55 azure linux-2core-8gb TestAccept
3:52 aws-windows-latest-4core-16gb TestAccept
3:51 gcp linux-2core-8gb TestAccept
3:49 azure-windows-latest-4core-16gb TestAccept
3:44 gcp-windows-latest-4core-16gb TestAccept

@andrewnester
andrewnester added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit f6ecf45 Nov 11, 2026
28 checks passed
@andrewnester
andrewnester deleted the andrewnester/pr-review-skill-doc-comments branch November 11, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants