Repository navigation
pr-review skill: look beyond the diff when collecting context - #7466
Merged
Merged
Conversation
andrewnester
force-pushed
the
andrewnester/pr-review-skill-context
branch
from
November 11, 2026 14:25
4c4cc3b to
b44c5fe
Compare
andrewnester
requested review from
janniklasrose and
pietern
and removed request for
renaudhartert-db
November 11, 2026 14:25
janniklasrose
approved these changes
Nov 11, 2026
andrewnester
enabled auto-merge
November 11, 2026 14:59
Add the checks that found the main issue in several recent reviews but are not in the skill: how far the branch is behind main and what moved there, stale generated files outside the diff, hunks the description does not explain, old values of changed constants and their copies, dead triggers for new options, pinned third-party tools, goroutine fan-out bounds, schema regeneration for fields that accept a new YAML kind, decision markers as stored values, messages left stale by a lifted restriction, and reading earlier review threads before posting. Co-authored-by: Isaac <no-reply@databricks.com>
andrewnester
force-pushed
the
andrewnester/pr-review-skill-context
branch
from
November 11, 2026 15:08
b44c5fe to
7630f61
Compare
Collaborator
✅ Integration test reportCommit: 7630f61
Top 7 slowest tests (at least 2 minutes):
|
pietern
reviewed
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds context checks the skill lacked: distance from main and what moved there, stale generated files outside the diff, unexplained hunks, old values of changed constants and their copies, dead triggers, pinned third-party tools, goroutine fan-out bounds, schema regeneration for new YAML kinds, decision markers as stored values, messages left stale by a lifted restriction, and reading earlier review threads before posting.
Why
Each item was the main finding in a recent review and came from outside the skill.
Tests
Docs only.
This pull request and its description were written by Isaac.