Repository navigation
acceptance: alerts/basic: check only 'does not exist' after destroy - #7492
Merged
Merged
Conversation
…/basic The backend now returns "Tree node with id ... does not exist" instead of "Alert with ID '...' does not exist." for a deleted alert. Co-authored-by: Isaac <no-reply@databricks.com>
github-actions
Bot
added
DABs
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Contributor
Author
fix testserver as well |
Collaborator
✅ Integration test reportCommit: 8853745
Top 11 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Nov 11, 2026
Contributor
Author
Done in #7509. While doing it I found that the testserver's alert behaviour differed from the cloud in more than the message. On AWS a trashed alert is still readable (200, AI agent (harness_auto, isaac_claude, opus5.5) |
Collaborator
❌ Integration test reportCommit: 56dd253
318 interesting tests: 177 MISS, 131 FAIL, 7 KNOWN, 3 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
tedjt
pushed a commit
to tedjt/cli
that referenced
this pull request
Nov 12, 2026
…rts (databricks#7509) ## Changes `libs/testserver` now answers alert get/update/trash the way the cloud does for trashed, purged and unknown alerts: | state | get | update | trash | |---|---|---|---| | trashed (not purged) | 200, `lifecycle_state: DELETED` | 400 `INVALID_PARAMETER_VALUE` `Cannot move node '<file>' (ID: <id>) because it is in trash folder` | 400 `BAD_REQUEST` `Alert <id> is already trashed` (purge still succeeds) | | purged | 404 `NOT_FOUND` `Tree node with id <id> does not exist` | same | same | | never existed | 404 `NOT_FOUND` `Alert with id <id> not found or has no folder node internal name` | same as get | 404 `NOT_FOUND` `Alert with id <id> not found` | Before this, get returned 404 with the old `Alert with ID '<id>' does not exist.` message for both trashed and missing alerts, and update/trash returned a bare 404 with no body. Update and trash of a trashed alert succeeded. New local test `acceptance/cmd/workspace/alerts-v2-not-found` records this matrix. ## Why Follow-up to databricks#7492, where the review asked to fix the testserver as well. That PR left the old message in place. Decisions: - The test is local-only. The expected output was recorded on AWS with the same script, with two known differences: on trash-again the cloud's message has a different UUID than the alert id, and on update the cloud's file name has a timestamp suffix (the file is renamed when trashed). Neither is worth modelling. - Purged ids are kept in a set so the testserver can tell "purged" from "never existed", which the cloud reports differently. - Body validation on create (e.g. the cloud requires a threshold for `EQUAL`) is out of scope. ## Tests - `go test ./acceptance -run TestAccept/cmd/workspace/alerts-v2-not-found` passes locally. - Every local acceptance test that mentions alerts passes. The same `bundle/migrate/*`, `bundle/state/*` and `bundle/user_agent/simple` failures show up on a clean main in this environment, so they are unrelated. - Cloud (AWS): ran the same script with `Cloud = true` via `testme-aws` to capture the responses above. ## Dashboard: Follow-up to [error/3324](http://go/cli/dashboard/error/3324?main=1&pr=1&end=2026-11-11T17:00:00Z&last=2d). It does not fix a failing test, because databricks#7492 already made the cloud test pass: | link | failure | |---|---| | [error/3324](http://go/cli/dashboard/error/3324?main=1&pr=1&end=2026-11-11T17:00:00Z&last=2d) | `Error: Tree node with id [ALERT_ID] does not exist` | This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
In
bundle/resources/alerts/basic, the check that the alert is gone afterbundle destroynow asserts only that thealerts-v2 get-alerterror containsdoes not exist. It no longer records the full backend message. It follows the samemusterr ... &> LOG.x+contains.pypattern used inacceptance/cmd/api/response-handling.Why
Since 2026-11-10 ~18:00 UTC the backend returns a different not-found message for a deleted alert, on AWS, Azure and GCP:
The test only needs to show that the alert was deleted. The exact wording is backend-owned and has now changed once, so matching the stable part keeps the test from breaking on the next rewording.
Decisions:
ALERT_IDreplacement. Failures began at the same time on all three clouds across several different CLI commits, which points to a backend rollout.does not exist, so local and cloud runs both pass.Tests
go test ./acceptance -run 'TestAccept/bundle/resources/alerts/basic'passes.testme-aws -count=1 -run 'TestAccept/bundle/resources/alerts/basic'passes forDMS=andDMS=trueagainst the current backend.Dashboard:
Error: Tree node with id [ALERT_ID] does not exist(expectedError: Alert with ID '[ALERT_ID]' does not exist.)This pull request and its description were written by Isaac.