Repository navigation
acc: alerts-v2-not-found: label lifecycle_state, name cloud differences - #7546
Merged
Merged
Conversation
…fferences Co-authored-by: Isaac <no-reply@databricks.com>
github-actions
Bot
added
the
test-only-fix
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=0 unreleased=0 coverage=1 failing=0
|
denik
changed the title
Collaborator
✅ Integration test reportCommit: eaa0003
Top 7 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 12, 2026 13:23
andrewnester
approved these changes
Nov 12, 2026
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 14, 2026
…abricks#7561) ## Changes Section 1 now says that when a PR description points at a review thread on another PR, read that thread after forming your own view and check the new text answers the ask made there. ## Why Follow-up PRs (databricks#7546, databricks#7541, databricks#7542) carry their intent in a parent PR's thread; the skill only covered the description and left the thread unread. ## Tests Skill text only. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #7509, addressing review comments that arrived after it merged. Both are in
acceptance/cmd/workspace/alerts-v2-not-found:get-alertnow projectsjq '{lifecycle_state}', matchingalerts/with_file/script, so the golden labels the value instead of printing a bareDELETED.Cloud = truewithout knowing about them.Why
Review feedback on #7509.
Tests
go test ./acceptance -run TestAccept/cmd/workspace/alerts-v2-not-foundpasses locally.Dashboard:
Follow-up only. No failing test is fixed here. Related: error/3324 (
Error: Tree node with id [ALERT_ID] does not exist).This pull request and its description were written by Isaac.