Skip to content

Forward /review comment IDs for progress reactions - #7772

Draft
janniklasrose wants to merge 1 commit into
mainfrom
janniklasrose/cli-review-comment-reactions
Draft

janniklasrose wants to merge 1 commit into
mainfrom
janniklasrose/cli-review-comment-reactions

Conversation

@janniklasrose

Copy link
Copy Markdown
Member

Changes

Forward the original /review comment ID to the review backend. Automatic reviews send an empty comment ID.

Why

Let the review bot acknowledge CLI review requests with 👀 and replace it with 🎉 only after publishing the review. Reaction failures do not block reviews.

Requires https://github.com/databricks-eng/eng-dev-ecosystem/pull/1622 to merge first so the backend accepts the new optional input.

Tests

  • All 15 existing review authorization tests passed.
  • The changed workflow passed actionlint and YAML formatting.
  • Executed the dispatch script against a simulated backend, confirming comment and empty-comment inputs are forwarded; caller-to-backend reaction scenarios passed locally.

This PR was created with GitHub MCP.

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 397fe36

Run: 44309772350

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 272 19 15:03
💚​ aws-windows-latest-4core-16gb 1 274 17 11:34
💚​ azure linux-2core-8gb 1 271 19 15:53
💚​ azure-windows-latest-4core-16gb 1 273 17 12:03
💚​ gcp linux-2core-8gb 1 272 19 14:18
💚​ gcp-windows-latest-4core-16gb 1 274 17 9:48
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 35 slowest tests (at least 2 minutes):
duration env testname
5:05 gcp linux-2core-8gb TestFilerWorkspaceFilesExtensionsDelete
4:20 aws-windows-latest-4core-16gb TestAccept
4:07 azure-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files_extensions
3:50 aws linux-2core-8gb TestImportDirDoesNotOverwrite
3:35 azure linux-2core-8gb TestFilerWorkspaceNotebook/pyNb.py
3:31 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
3:30 gcp-windows-latest-4core-16gb TestAccept
3:25 azure-windows-latest-4core-16gb TestAccept
3:10 azure-windows-latest-4core-16gb TestFilerWorkspaceNotebook/scalaNb.scala
3:07 aws-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsStat
3:06 azure-windows-latest-4core-16gb TestImportDirDoesNotOverwrite
3:00 aws linux-2core-8gb TestImportDir
2:58 aws linux-2core-8gb TestFilerRecursiveDelete/workspace_files_extensions
2:57 aws-windows-latest-4core-16gb TestSyncIncrementalFileSync
2:50 gcp linux-2core-8gb TestImportDir
2:49 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsStat
2:46 azure linux-2core-8gb TestFilerRecursiveDelete/workspace_files
2:44 aws linux-2core-8gb TestFilerRecursiveDelete/workspace_files
2:43 aws linux-2core-8gb TestFilerWorkspaceNotebook/pythonJupyterNb.ipynb
2:37 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead
2:34 gcp linux-2core-8gb TestFilerWorkspaceFilesExtensionsStat
2:28 azure linux-2core-8gb TestFilerReadWrite/workspace_files
2:27 gcp-windows-latest-4core-16gb TestImportDirDoesNotOverwrite
2:21 azure linux-2core-8gb TestSyncIncrementalFileSync
2:18 azure linux-2core-8gb TestFilerReadDir/workspace_files
2:18 aws-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
2:16 aws-windows-latest-4core-16gb TestFilerReadWrite/workspace_files
2:14 gcp linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
2:11 gcp linux-2core-8gb TestImportDirDoesNotOverwrite
2:08 gcp-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files
2:05 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsDelete
2:03 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
2:02 azure-windows-latest-4core-16gb TestFilerWorkspaceNotebook/pyNb.py
2:01 azure-windows-latest-4core-16gb TestFilerReadWrite/workspace_files
2:00 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsRead

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants