Skip to content

ci: don't fail test jobs when the gotestsum artifact upload fails - #7781

Merged
denik merged 1 commit into
mainfrom
denik/ci-upload-continue-on-error
Nov 18, 2026
Merged

denik merged 1 commit into
mainfrom
denik/ci-upload-continue-on-error

Conversation

@denik

@denik denik commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Changes

Mark the "Upload gotestsum JSON output" step in push.yml as continue-on-error: true.

Why

Twice in three days on main, a task test (macos, ...) job ran its whole test suite green (PASS Package acceptance) and was still marked failed. In both cases only the artifact upload had failed:

##[error]Failed to CreateArtifact: Unable to make request: ENOTFOUND
...
No failed tests found in test-output.json (the failure may be outside the test run).

That artifact (test-output-<os>-<deployment>) is only a debugging aid for timing. No job in this workflow downloads it. A failed upload also skipped the "Check no files changed" step. With this change:

  • the job reports the real test result;
  • the files-changed check still runs;
  • "Summarize failed tests" no longer prints a misleading "no failed tests" summary.

The release-build artifacts are consumed downstream, so I left them unchanged.

The third run in this group (error/3743) was a Windows job whose hosted runner "lost communication with the server" partway through the tests. That is a GitHub runner issue and is not addressed here.

Dashboard

error snippet
error/3743 Failed to CreateArtifact: Unable to make request: ENOTFOUND (Package failed with no test reporting a failure)

Tests

None. This is a workflow-only change.

AI agent (opus5.5, isaac_claude)

This pull request and its description were written by Isaac.

Co-authored-by: Isaac <no-reply@databricks.com>
@denik denik added the ai-auto Deprecated: use factory-generated instead. label Nov 18, 2026
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 354c7e7

Run: 44365753084

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 273 19 7:24
✅​ aws-windows-latest-4core-16gb 275 17 7:11
✅​ azure linux-2core-8gb 272 19 7:47
✅​ azure-windows-latest-4core-16gb 274 17 6:09
✅​ gcp linux-2core-8gb 273 19 8:05
✅​ gcp-windows-latest-4core-16gb 275 17 5:55
Top 6 slowest tests (at least 2 minutes):
duration env testname
3:30 azure-windows-latest-4core-16gb TestAccept
3:21 aws-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
3:13 gcp-windows-latest-4core-16gb TestAccept
2:57 aws-windows-latest-4core-16gb TestAccept
2:41 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsStat
2:01 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsDelete

@denik
denik marked this pull request as ready for review November 18, 2026 18:29
@denik
denik requested a review from a team as a code owner November 18, 2026 18:29
@denik
denik requested review from Sankalp-Mittal, andrewnester and rugpanov and removed request for rugpanov November 18, 2026 18:29

@review-oss-bot review-oss-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me — no issues found.

@denik
denik added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 749c68f Nov 18, 2026
33 checks passed
@denik
denik deleted the denik/ci-upload-continue-on-error branch November 18, 2026 20:09
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

❌ Integration test report

Commit: 749c68f

Run: 44388189318

Env ❌​FAIL 🟨​KNOWN 🔄​flaky 💚​RECOVERED ✅​pass 🙈​skip Time
❌​ aws linux-2core-8gb 2 1 1 14 1628 1386 250:44
❌​ aws-windows-latest-4core-16gb 3 1 14 1544 1414 251:01
❌​ azure linux-2core-8gb 9 1 14 1602 1394 244:26
❌​ azure-windows-latest-4core-16gb 2 1 7 14 1518 1422 245:36
🔄​ gcp linux-2core-8gb 2 14 1617 1392 242:58
🔄​ gcp-windows-latest-4core-16gb 2 15 1532 1420 249:31
27 interesting tests: 14 RECOVERED, 9 FAIL, 3 flaky, 1 KNOWN
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
🟨​ TestAccept 🟨​K 🟨​K 🟨​K 🟨​K 🔄​f 💚​R
❌​ TestAccept/bundle/deployment/bind/alert ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestAccept/bundle/deployment/bind/alert/DMS= ✅​p ✅​p ❌​F 🔄​f ✅​p ✅​p
❌​ TestAccept/bundle/deployment/bind/alert/DMS=true ✅​p ✅​p ❌​F 🔄​f ✅​p ✅​p
❌​ TestAccept/bundle/generate/alert ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestAccept/bundle/generate/alert/DMS= ✅​p ✅​p ❌​F 🔄​f ✅​p ✅​p
❌​ TestAccept/bundle/generate/alert/DMS=true ✅​p ✅​p ❌​F 🔄​f ✅​p ✅​p
❌​ TestAccept/bundle/resources/apps/inline_config ❌​F ❌​F ❌​F ❌​F ✅​p ✅​p
❌​ TestAccept/bundle/resources/apps/inline_config/DMS= 🔄​f ❌​F ❌​F 🔄​f ✅​p 🔄​f
❌​ TestAccept/bundle/resources/apps/inline_config/DMS=true ❌​F ❌​F ❌​F ❌​F ✅​p 🔄​f
💚​ TestAccept/bundle/resources/apps/lifecycle-started 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-omitted 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS= 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-toggle 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-toggle/DMS= 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-toggle/DMS=true 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started/DMS= 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started/DMS=true 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/postgres_synced_tables/basic 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/postgres_synced_tables/basic/DMS= 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/postgres_synced_tables/recreate 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/postgres_synced_tables/recreate/DMS= 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/postgres_synced_tables/recreate/DMS=true 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🔄​ TestAccept/bundle/select/deletion_dependents ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p
🔄​ TestAccept/bundle/select/deletion_dependents/DMS=true ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p
🔄​ TestAccept/pipelines/run/refresh-flags ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
Top 50 slowest tests (at least 2 minutes):
duration env testname
10:56 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
10:55 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
10:34 azure linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
10:31 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:59 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:51 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:49 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:35 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:27 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:08 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:06 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
8:52 aws linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=true
8:51 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
8:44 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
8:40 azure-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/simple/DMS=
8:19 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
8:18 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
8:09 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
8:06 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=true
8:05 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=true
7:38 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=
7:31 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
7:28 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
7:16 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
7:16 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/resize-terminated-fallback/DMS=true
7:11 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
7:06 aws-windows-latest-4core-16gb TestAccept/pipelines/run/refresh-flags
6:53 aws linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=
6:39 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=
6:38 azure linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=true
6:32 gcp linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=true
6:31 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
6:29 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/update-after-create/DMS=true
6:26 azure linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=
6:17 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
6:15 gcp linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=
6:15 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/simple/DMS=
6:10 azure-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
5:59 azure linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
5:58 azure-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
5:50 azure-windows-latest-4core-16gb TestAccept/pipelines/run/refresh-flags
5:46 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
5:29 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
5:27 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
5:22 azure linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
5:20 gcp-windows-latest-4core-16gb TestAccept/pipelines/run/refresh-flags
5:19 azure-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
5:18 aws linux-2core-8gb TestAccept/bundle/deploy/spark-jar-task/DMS=
5:15 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
5:14 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-toggle/DMS=true

@denik denik added factory-generated and removed ai-auto Deprecated: use factory-generated instead. labels Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants