Fix hyphen catalog name - #226
Closed
lammic wants to merge 6 commits into
Closed
Conversation
…0.10 Feature/v0.0.10
…0.10 Feature/v0.0.10
…0.10 - Replacing DLT with Lakeflow Declarative Pipelines - Changed direct publishing mode to default publishing mode in docs
ravi-databricks
requested review from
brij-raghuwanshi-db,
ganeshchand and
ravi-databricks
September 8, 2025 17:37
ravi-databricks
requested changes
Sep 12, 2025
| "\nERROR: 'uc_catalog_name' can only contain ASCII letters ('a' - 'z', 'A' - 'Z')," | ||
| " digits ('0' - '9'), and underbar ('_'). Must also not start with a digit. Exiting." | ||
| ) | ||
| exit(1) |
Contributor
There was a problem hiding this comment.
Why not put into base class instead of duplicating this validation in every demo class?
Author
There was a problem hiding this comment.
yes, we can. I checked the page https://docs.databricks.com/aws/en/sql/language-manual/sql-ref-identifiers, we need then to implement a more robust check. Are we also supporting delimited identifiers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for issue #225.