Feature/v0.0.10 - #229
Merged
Merged
Conversation
ravi-databricks
commented
Sep 12, 2025
ravi-databricks
commented
Contributor
- Added support for CDC Multiple sequence cols PR
- Added custom function support for kafka and delta tables PR
- Update project overview and features tables in docs + readme
- Updated release note and change logs
Adding multiple col support for auto_cdc api
Added custom function support for kafka and delta tables
ganeshchand
reviewed
Sep 15, 2025
| sequence_by = cdc_apply_changes.sequence_by | ||
| if ',' in sequence_by: | ||
| sequence_cols = [col.strip() for col in sequence_by.split(',')] | ||
| sequence_by = struct(*sequence_cols) # Use struct() from pyspark.sql.functions |
There was a problem hiding this comment.
how do we guarantee consistent ordering of the sequencing columns. "col1, col2" vs. "col2, col1" are different structs and will have a different sorting and uniqueness logic.
Contributor
Author
There was a problem hiding this comment.
Yes! Code preserves the order exactly as provided:
- split(',') returns tokens in the original order
- struct(sequence_cols) builds the struct with fields in that same order
So "col1, col2" and "col2, col1" produce different structs, which is expected and will change sequencing semantics.
ganeshchand
requested changes
Sep 15, 2025
ganeshchand
left a comment
ganeshchand
left a comment
There was a problem hiding this comment.
overall, it looks good. just one concern regarding the sequency by columns ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.