Drop the DataChain install flags from the Studio chart - #879
Open
0x2b3bfa0 wants to merge 1 commit into
Open
Conversation
`DATACHAIN_ENABLED` has been dead since datachain-ai/studio#13096, and datachain-ai/studio#13122 drops `DATACHAIN_UDF_ENABLED`, so neither ConfigMap key has a reader any more. `global.datachain.udfEnabled` gated nothing's existence — it was purely a replica-count override on the DataChain worker Deployment and HPA. The Deployment, its ConfigMap, ServiceAccount, Role/RoleBinding, ClusterRole/ClusterRoleBinding, PVC, ResourceQuota and the suspended CronJob Job template all rendered either way. So there is no replacement knob: `studioDatachainWorker.replicaCount` and `studioDatachainWorker.autoscaling.minReplicas/maxReplicas` already say what `udfEnabled: false` said, and `udfEnabled` was a second, chart-global spelling that silently overrode them. `global.datachain` itself stays — `clickHouse.dsn` still lives under it and is read by secret-studio.yaml. Behaviour change: the flag defaulted to false, so a stock install declared `replicaCount: 1` but rendered `replicas: 0`. It now renders 1. Claude-Session: https://claude.ai/code/session_01Eb5QaLhxciBiarrZDdJ1ks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to https://github.com/datachain-ai/studio/pull/13122, itself a follow-up to https://github.com/datachain-ai/studio/pull/13096#issuecomment-5138512887. Being released in parallel.
The ConfigMap keys
DATACHAIN_ENABLEDhas had no reader since datachain-ai/studio#13096 merged. datachain-ai/studio#13122 removes the last reader ofDATACHAIN_UDF_ENABLED. Both go, along with the$datachain/$datachainClickhouselocals that became unused once they did —secret-studio.yamlkeeps its own copies forclickHouse.dsn.Why no replacement flag
global.datachain.udfEnabledgated nothing's existence. It was purely a replica-count override in two spots:The Deployment itself,
configmap-studio-datachain-worker, the ServiceAccount, Role/RoleBinding, ClusterRole/ClusterRoleBinding, the PVC, the ResourceQuota and the suspended CronJob Job template all rendered regardless.udfEnabled: falsenever meant "no worker component" — it meant "scale the worker to zero".So there's no replacement knob, because the knob already exists:
studioDatachainWorker.replicaCountandstudioDatachainWorker.autoscaling.minReplicas/maxReplicassay exactly whatudfEnabled: falsesaid.udfEnabledwas a second, chart-global spelling that silently won over the documented per-component values.A
studioDatachainWorker.enabledflag would have been wrong twice over — this chart'senabledidiom means render or don't render (studioPypiCache.enabledgates its Deployment/Service/PVC at line 1;studioBackend.datachainApi.enabledgates the Service and Ingress backend), which is a strictly bigger hammer than what's being removed, and it would duplicatereplicaCount.global.datachainitself stays —clickHouse.dsnstill lives under it.udfEnableddefaulted to false, so a stock install declaredreplicaCount: 1but renderedreplicas: 0. It now renders1. This deletes an override that contradicted the value it sat on top of.Anyone who wants no DataChain workers sets
studioDatachainWorker.replicaCount: 0(orautoscaling.minReplicas/maxReplicas: 0). Chart minor-bumped to0.21.0accordingly.dev and prod both set
udfEnabled: truetoday, so neither environment changes — see the companion platform PR.Testing
helm lintpasses.helm templatediffed againstmain:With the real prod values (
platform/k8s/prod/studio/studio-values{,-env}.yaml) — the only non-cosmetic change is the two ConfigMap keys disappearing. No replica or HPA change. Remaining diff is thehelm.sh/chartlabel and the ConfigMap/Secret checksum annotations, both expected.Stock defaults — the two ConfigMap keys, plus the intended
replicas: 0→replicas: 1.HPA branch, exercised explicitly since prod doesn't autoscale this worker:
autoscaling.enabled=true,udfEnabledunset0/01/5autoscaling.enabled=true,udfEnabled=true1/51/5i.e. identical wherever
udfEnabledwas set, and honouring the declared values where it wasn't.https://claude.ai/code/session_01Eb5QaLhxciBiarrZDdJ1ks