Have ToJson() match the default formatter's escaping behavior - #8
Open
nblumhardt-ro wants to merge 1 commit into
Open
Have ToJson() match the default formatter's escaping behavior#8nblumhardt-ro wants to merge 1 commit into
ToJson() match the default formatter's escaping behavior#8nblumhardt-ro wants to merge 1 commit into
Conversation
… unusable for non-Latin languages, otherwise). Assisted-by: Claude:claude-fable-5-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.Text.Json's default formatting also escapes for HTML and anything non-ASCII (which makes sense as a defense-in-depth strategy in web apps). This doesn't work for a formatting library: content with +, with non-Latin character sets, etc., becomes unreadable.
The PR relaxes this to regular safe JSON escaping (the
Unsafe***is a misnomer, in my humble opinion, but a good signpost to make us think, I guess).