Get-DbaRandomizedType - Stop eating the caller loop when the type list is missing - #10648
Merged
potatoqualitee merged 1 commit intoSep 1, 2026
Merged
Conversation
…t is missing The import guard in the begin block called Stop-Function -Continue, but no loop encloses it: without -EnableException the continue escaped the command and consumed an iteration of whatever loop the caller was running in. Now it stops and returns; the process block already guards with Test-FunctionInterrupt. Part of the #10638 inventory. No regression test, because the guard only fires when the module's own shipped en.randomizertypes.csv is missing, which cannot be triggered without corrupting the installation; the existing tests confirm the healthy path is unchanged. References #10638 (do Get-DbaRandomizedType) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
potatoqualitee
approved these changes
Aug 30, 2026
potatoqualitee
left a comment
potatoqualitee
left a comment
Member
There was a problem hiding this comment.
Reviewed the complete current head, begin/process interrupt semantics, existing coverage, and exact-head CI evidence. No material correctness or compatibility issues found.
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Twelfth fix from the #10638 inventory, the smallest possible shape: the csv import guard in the begin block called
Stop-Function -Continuewith no enclosing loop, escaping into the caller's loop on failure. Stop-and-returnnow; the process block already guards withTest-FunctionInterrupt.Tests
No new regression test: the guard fires only when the module's own shipped
bin\randomizer\en.randomizertypes.csvis missing, which cannot be triggered without corrupting the installation. The existing tests (which exercise the healthy import on every run) stay green via the lab harness.References #10638
created by Claude and reviewed by Andreas Jordan
🤖 Generated with Claude Code