test: use explicit handles the sequence can never mint

RequiredMetadataIT and ItemHandleCheckerIT planted a random numeric
handle (1000-1999) that handle_seq reaches late in the module run; the
sequence mint path does no existence check, so the flush of whichever
test was minting at that moment died on the handle unique index. Replace
the random handles with deterministic non-numeric suffixes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: milanmajchrak

dspace-api/src/test/java/org/dspace/curate/ItemHandleCheckerIT.java

@@ -19,7 +19,6 @@
 import java.io.IOException;
 import java.sql.SQLException;
 import java.util.List;
-import java.util.Random;
 
 import okhttp3.mockwebserver.Dispatcher;
 import okhttp3.mockwebserver.MockResponse;
@@ -58,7 +57,9 @@
 public class ItemHandleCheckerIT extends AbstractIntegrationTestWithDatabase {
     private static final String TASK_NAME = "checkhandles";
 
-    private static final String HANDLE_COLLECTION = "123456789/" + randomString();
+    // Non-numeric suffix the handle sequence can never mint, unique to this class so it cannot
+    // clash with leftover handle rows of other tests either.
+    private static final String HANDLE_COLLECTION = "123456789/handle-checker-test";
 
     private static final String HANDLE_ITEM1 = HANDLE_COLLECTION + "-1";
     private static final String HANDLE_ITEM2 = HANDLE_COLLECTION + "-2";
@@ -280,10 +281,4 @@ private String getIdentifierUri(Item item) {
     private List<MetadataValue> getIdentifierUris(Item item) {
         return itemService.getMetadata(item, "dc", "identifier", "uri", Item.ANY);
     }
-
-    private static String randomString() {
-        Random r = new Random();
-        // Generate random integers in range 1000 to 1999
-        return String.valueOf(1000 + r.nextInt(1000));
-    }
 }

dspace-api/src/test/java/org/dspace/curate/RequiredMetadataIT.java

@@ -15,7 +15,6 @@
 
 import java.io.IOException;
 import java.sql.SQLException;
-import java.util.Random;
 
 import org.dspace.AbstractIntegrationTestWithDatabase;
 import org.dspace.authorize.AuthorizeException;
@@ -44,7 +43,9 @@
 public class RequiredMetadataIT extends AbstractIntegrationTestWithDatabase {
     private static final String TASK_NAME = "requiredmetadata";
 
-    private static final String HANDLE_COLLECTION = "123456789/" + randomString();
+    // Non-numeric suffix the handle sequence can never mint, unique to this class so it cannot
+    // clash with leftover handle rows of other tests either.
+    private static final String HANDLE_COLLECTION = "123456789/required-metadata-test";
     private static final String HANDLE_ITEM1 = HANDLE_COLLECTION + "-1";
     private static final String HANDLE_ITEM2 = HANDLE_COLLECTION + "-2";
     private static final String HANDLE_ITEM3 = HANDLE_COLLECTION + "-3";
@@ -154,10 +155,4 @@ private static String successResultForItem(Item item) {
         return "Item: " + item.getHandle() + " has all required fields";
     }
 
-    private static String randomString() {
-        Random r = new Random();
-        // Generate random integers in range 1000 to 1999
-        return String.valueOf(1000 + r.nextInt(1000));
-    }
-
 }

dspace-api/src/test/java/org/dspace/xmlworkflow/XmlWorkflowFactoryTest.java

@@ -70,7 +70,9 @@ public void init() {
             this.owningCommunity = communityService.create(null, context);
             this.mappedCollection =
                     this.collectionService.create(context, owningCommunity, "123456789/workflow-test-1");
-            this.nonMappedCollection = this.collectionService.create(context, owningCommunity, "123456789/999");
+            // Non-numeric suffix so the handle sequence can never mint a colliding handle
+            this.nonMappedCollection =
+                    this.collectionService.create(context, owningCommunity, "123456789/workflow-test-2");
             //we need to commit the changes so we don't block the table for testing
             context.restoreAuthSystemState();
         } catch (SQLException e) {