TUL/fix: make Subject a plain facet to stop vocabulary=undefined 400s (#781) (#1362)

* TUL/fix: make Subject a plain facet to stop vocabulary=undefined 400s (#781)

dc.subject at TUL is free-text keywords, not a controlled hierarchy. The
searchFilterSubject facet was HierarchicalSidebarFacetConfiguration, which
makes the Angular UI (SearchHierarchyFilterComponent) probe
/submission/vocabularyEntryDetails/search/top with vocabulary=undefined on
every search-page render (getVocabularyEntry() returns undefined because no
srsc vocabulary is enabled), producing an HTTP 400 each time.

Switch searchFilterSubject to a plain DiscoverySearchFilterFacet and drop the
hierarchical '::' splitter. The facet renders as a normal text facet and no
longer triggers the vocabulary tree probe.

Note: run `dspace index-discovery -b` after deploy; this changes how
dc.subject is indexed for faceting.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* TUL/test: expect Subject facet as text (not hierarchical) after facet change

The Subject facet was switched from HierarchicalSidebarFacetConfiguration to a
plain DiscoverySearchFilterFacet, so the REST API now reports facetType/type
"text" for subject (same as author). Update the shared matchers accordingly:
- FacetEntryMatcher.subjectFacet: facetType "hierarchical" -> "text"
- SearchFilterMatcher.subjectFilter: type "hierarchical" -> "text"

Fixes the 28 DiscoveryRestControllerIT (and ClarinDiscoveryRestControllerIT)
assertions that go through these matchers.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: milanmajchrak <minptai7@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: 3 people

dspace-server-webapp/src/test/java/org/dspace/app/rest/matcher/FacetEntryMatcher.java

@@ -48,7 +48,7 @@ public static Matcher<? super Object> authorFacetWithMinMax(boolean hasNext, Str
     public static Matcher<? super Object> subjectFacet(boolean hasNext) {
         return allOf(
             hasJsonPath("$.name", is("subject")),
-            hasJsonPath("$.facetType", is("hierarchical")),
+            hasJsonPath("$.facetType", is("text")),
             hasJsonPath("$.facetLimit", any(Integer.class)),
             hasJsonPath("$._links.self.href", containsString("api/discover/facets/subject")),
             hasJsonPath("$._links", matchNextLink(hasNext, "api/discover/facets/subject"))

dspace-server-webapp/src/test/java/org/dspace/app/rest/matcher/SearchFilterMatcher.java

@@ -44,7 +44,7 @@ public static Matcher<? super Object> subjectFilter() {
         return allOf(
                 hasJsonPath("$.filter", is("subject")),
                 hasJsonPath("$.hasFacets", is(true)),
-                hasJsonPath("$.type", is("hierarchical")),
+                hasJsonPath("$.type", is("text")),
                 hasJsonPath("$.openByDefault", is(false)),
                 checkOperators()
 

dspace/config/spring/api/discovery.xml

@@ -2444,7 +2444,11 @@
 
     </bean>
 
-    <bean id="searchFilterSubject" class="org.dspace.discovery.configuration.HierarchicalSidebarFacetConfiguration">
+    <!-- TUL: dc.subject holds free-text keywords, not a controlled hierarchy, so this is a
+         plain facet. Using HierarchicalSidebarFacetConfiguration makes the Angular UI probe
+         vocabularyEntryDetails/search/top with vocabulary=undefined (no srsc vocabulary is
+         wired for TUL), yielding an HTTP 400 on every search-page render. See dspace-customers#781. -->
+    <bean id="searchFilterSubject" class="org.dspace.discovery.configuration.DiscoverySearchFilterFacet">
         <property name="indexFieldName" value="subject"/>
         <property name="metadataFields">
             <list>
@@ -2454,8 +2458,6 @@
         <property name="facetLimit" value="5"/>
         <property name="sortOrderSidebar" value="COUNT"/>
         <property name="sortOrderFilterPage" value="COUNT"/>
-        <property name="splitter" value="::"/>
-
     </bean>
 
     <bean id="searchFilterIssued" class="org.dspace.discovery.configuration.DiscoverySearchFilterFacet">