Commit 5ed36b3
build: pull dspace-dependencies from dataquest, not upstream (#1372)
The v9 Dockerfiles still pull vanilla's dspace/dspace-dependencies:dspace-9_x,
so the dataquest/dspace-dependencies image our own CI publishes is never
consumed and three jobs are serialised behind a build whose output is thrown
away. dtq-dev has always pulled dataquest/dspace-dependencies:dspace-7_x.
Worse, upstream's dspace-9_x tag is a moving target and has already drifted away
from us: it is now 9.4-SNAPSHOT pinning maven-enforcer-plugin 3.6.3, while this
branch is 9.3 pinning 3.6.2. So its Maven cache never matches our POMs, every
build re-resolves from Maven Central, and Central intermittently answers 403 --
that is what failed the first dspace build on #1367 (died in 0.7s on
maven-enforcer-plugin:3.6.2, while dspace-test and dspace-cli, same image and
same second, built through fine). The drift only widens as vanilla moves toward
9.4.
Point the base image at our own dependencies image, tagged with the branch name
because non-default branches are tagged type=ref,event=branch by the reusable
workflow. The dspace-dependencies job builds from this branch's POMs, so
enforcer 3.6.2 is cached and no Central round-trip is needed.
Ordering: on push, needs: dspace-dependencies guarantees the dependencies image
is built AND pushed before any job pulls it, so the branch bootstraps itself.
PR builds reuse the last pushed image (as on dtq-dev). This therefore requires
#1367 to be merged first, so that the first push publishes
dataquest/dspace-dependencies:dtq-dev-9-base.
Note local builds now need that image too:
docker pull dataquest/dspace-dependencies:dtq-dev-9-base
(or override with --build-arg DSPACE_VERSION=...), same as on dtq-dev.
Co-authored-by: Milan Majchrák <minptai7@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent c40c5c6 commit 5ed36b3
3 files changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
0 commit comments