ZCU-PUB/The bitstream name is encoded in the URL. Updated the test to test special characters in the URL (#930)

Author: milanmajchrak

dspace-server-webapp/src/test/java/org/dspace/app/sword2/Swordv2IT.java

@@ -258,7 +258,8 @@ public void depositAndEditViaSwordTest() throws Exception {
         // Add required headers
         HttpHeaders headers = new HttpHeaders();
         headers.setContentType(MediaType.MULTIPART_FORM_DATA);
-        headers.setContentDisposition(ContentDisposition.attachment().filename("example.zip").build());
+        // Test the file with spaces or special characters in the name
+        headers.setContentDisposition(ContentDisposition.attachment().filename("example .zip").build());
         headers.set("Packaging", "http://purl.org/net/sword/package/METSDSpaceSIP");
         headers.setAccept(List.of(MediaType.APPLICATION_ATOM_XML));
 

dspace-swordv2/src/main/java/org/dspace/sword2/SwordUrlManager.java

@@ -7,6 +7,8 @@
  */
 package org.dspace.sword2;
 
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
 import java.sql.SQLException;
 import java.util.List;
 
@@ -386,10 +388,10 @@ public String getBitstreamUrl(Bitstream bitstream)
 
             if (handle != null && !"".equals(handle)) {
                 bsLink = bsLink + "/bitstream/" + handle + "/" +
-                    bitstream.getSequenceID() + "/" + bitstream.getName();
+                    bitstream.getSequenceID() + "/" + URLEncoder.encode(bitstream.getName(), StandardCharsets.UTF_8);
             } else {
                 bsLink = bsLink + "/retrieve/" + bitstream.getID() + "/" +
-                    bitstream.getName();
+                    URLEncoder.encode(bitstream.getName(), StandardCharsets.UTF_8);
             }
 
             return bsLink;
@@ -401,7 +403,7 @@ public String getBitstreamUrl(Bitstream bitstream)
     public String getActionableBitstreamUrl(Bitstream bitstream)
         throws DSpaceSwordException {
         return this.getSwordBaseUrl() + "/edit-media/bitstream/" +
-            bitstream.getID() + "/" + bitstream.getName();
+            bitstream.getID() + "/" + URLEncoder.encode(bitstream.getName(), StandardCharsets.UTF_8);
     }
 
     public boolean isActionableBitstreamUrl(Context context, String url) {