Skip to content

[Port to dtq-dev] Issue dspace-customers#903: make REST root version prefix configurable #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 4 commits into from
Sep 11, 2026
Merged

[Port to dtq-dev] Issue dspace-customers#903: make REST root version prefix configurable #1405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad0e941
fix(rest): make REST root version prefix configurable (default "DSpace")
jr-rk Aug 11, 2026
6fe6678
fix(rest): fall back to default when dspace.version.prefix is blank
jr-rk Aug 12, 2026
58b3382
config: ship CLARIN-DSpace as the dtq-dev REST version prefix
jr-rk Sep 10, 2026
a575da5
fix: add CLARIN-DSpace as defaults
jr-rk Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dspace-server-webapp/src/main/java/org/dspace/app/rest/converter/RootConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ public RootRest convert(HttpServletRequest request) {
} else {
rootRest.setDspaceServer(dspaceUrl);
}
rootRest.setDspaceVersion("DSpace " + getSourceVersion());
String versionPrefix = configurationService.getProperty("dspace.version.prefix", "DSpace");
rootRest.setDspaceVersion(versionPrefix + " " + getSourceVersion());
Comment thread
jr-rk marked this conversation as resolved.
Outdated
rootRest.setBuildVersion(getBuildVersion());
return rootRest;
}
Expand Down
12 changes: 12 additions & 0 deletions dspace-server-webapp/src/test/java/org/dspace/app/rest/converter/RootConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public void setUp() throws Exception {
when(configurationService.getProperty("dspace.name")).thenReturn("dspacename");
when(configurationService.getProperty("dspace.server.url")).thenReturn(serverURL);
when(configurationService.getProperty("dspace.server.ssr.url", serverURL)).thenReturn(serverSSRURL);
when(configurationService.getProperty("dspace.version.prefix", "DSpace")).thenReturn("DSpace");

}

Expand Down Expand Up @@ -85,4 +86,15 @@ public void testCorrectInternalUrlSetFromConfigurationService() throws Exception
assertEquals(serverSSRURL, rootRest.getDspaceServer());
assertEquals("DSpace " + Util.getSourceVersion(), rootRest.getDspaceVersion());
}

@Test
public void testConfigurableVersionPrefix() throws Exception {
when(configurationService.getProperty("dspace.version.prefix", "DSpace")).thenReturn("CLARIN-DSpace");
request.setScheme("https");
request.setServerName("dspace-rest");
request.setServerPort(443);
request.setRequestURI("/server/api");
RootRest rootRest = rootConverter.convert(request);
assertEquals("CLARIN-DSpace " + Util.getSourceVersion(), rootRest.getDspaceVersion());
}
}
5 changes: 5 additions & 0 deletions dspace/config/dspace.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ dspace.ui.url = http://localhost:4000
dspace.name = DSpace at My University
dspace.shortname = DSpace

# Prefix for the version string exposed at the REST root (/server/api), rendered by the UI as
# the HTML <meta name="Generator"> value. Defaults to "DSpace" when unset; CLARIN/customer
# deployments may set e.g. "CLARIN-DSpace".
# dspace.version.prefix = DSpace
Comment thread
milanmajchrak marked this conversation as resolved.
Outdated

# Assetstore configurations have moved to config/modules/assetstore.cfg
# and config/spring/api/bitstore.xml.
# Additional storage options (e.g. Amazon S3) are available in `assetstore.cfg`
Expand Down
Loading