CLARIN-DSpace v9/Fix report-diff licence field mapping so the licences row is not silently dropped - #1433
Merged
milanmajchrak merged 1 commit intoSep 10, 2026
Conversation
report-diff-fields.json addresses the licence row as
/checks/[name=License summary]/report/licenses, but dtq-dev-9-base ships
that check as "License":
dspace/config/modules/healthcheck.cfg
healthcheck.checks = General Information, Checksum, Item summary,
User summary, Log Analyser Check, License, Embargo info
plugin.named.org.dspace.health.Check =
org.dspace.health.LicenseCheck = License
ReportDiff resolves a [name=...] segment against the check name recorded in
the stored report, so the mapping can never match and report-diff silently
drops the licences row from both the field mapping and the field order.
"License summary" is the name healthcheck.cfg uses on dtq-dev, which is
where this resource came from; HealthReportIT on this branch already
addresses the same check as "License".
healthcheck.cfg is deliberately not touched: the shipped check names are
correct, the resource was the outlier.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Follow-up to #1425 (card X-01), which brought
report-diff-fields.jsonacross whole.Description
That resource maps
[name=License summary], but 9-base'shealthcheck.cfgnames the checkLicense.The mapping can therefore never match, and
report-diffsilently drops the licences row — no error, nowarning, just a missing line in every diff report.
Two keys changed, in
fieldMappingsandfieldOrder.healthcheck.cfgis deliberately not touched: theshipped check names are the 9-base ones by an earlier decision (card BE-13), so the resource is what has to
follow. This is also kept out of BE-13's own branch, because BE-13 must not modify this file — its acceptance
criterion would become vacuous.
Instructions for Reviewers
Known, not fixed here
The same resource carries a second dead mapping,
[name=Metadata check]×2.org.dspace.health.MetadataCheckexists on
origin/dtq-devand is absent fromdtq-dev-9-base— that is a dropped fork class, and cardBE-13 is the one that brings it back. Fixing the mapping before the class exists would just move the dead
reference, so it is left for BE-13.
🤖 Generated with Claude Code