Fix: updated RootConverter's unit tests - #1440
Merged
milanmajchrak merged 2 commits intoSep 11, 2026
Merged
Conversation
…-DSpace instead of DSpace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(tests): adjust RootConverters unit tests to assert CLARIN-DSpace instead of DSpace
Problem description
Backported #1405 was merged but unit 2 unit tests failed:
Fix
Fixed
testConfigurableVersionPrefix, which stubbed dspace.version.prefix with a stale default arg ("DSpace") left over from before the prod default changed to "CLARIN-DSpace", causing Mockito's strict-stub runner to flag it as an unused stub (UnnecessaryStubbingException) since the real code never called getProperty with that argument. Updated the stub's default arg to match and changed its return value to a distinct "CustomPrefix" so the test actually verifies override behavior instead of duplicating setUp(), and added testBlankVersionPrefixFallsBackToDefault to cover the blank-value fallback path.