Clarin9/Save submission immediately when a type/sponsor/author field changes (#1489)

* Clarin9/Save submission immediately when a type/sponsor/author field changes

In the DSpace 9 upgrade, the CLARIN section-form lost the logic that persisted
the submission as soon as a type-bind controlling field (e.g. dc.type) or a
sponsor/author autocomplete value was picked. In v7, selecting such a value in
a dropdown fired an immediate section save (verified live on dev-5: choosing a
resource type triggers a PATCH). In v9 nothing was saved until the whole
section lost focus, so the choice could be lost.

Restore the v7 behaviour in SubmissionSectionFormComponent.onChange: when the
changed field is a type-bind controlling field or the sponsor/author field,
dispatch a section save immediately.

The set of type-bind controlling fields is owned by FormBuilderService in v9
(populated from `submit.type-bind.field`), so expose it via a new
getTypeFieldValues() accessor rather than duplicating the map in the component.
Form reconfiguration on type change is already handled reactively by v9's
type-bind machinery, so only the save is restored here.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Fix type-bind match to handle multi-segment controlling fields

Convert metadata to underscore notation instead of replacing only the
first underscore in the field id (addresses Copilot review).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: 3 people

src/app/shared/form/builder/form-builder.service.ts

@@ -708,4 +708,9 @@ export class FormBuilderService extends DynamicFormService {
     return this.getDefaultTypeBindModelId();
   }
 
+  /** Type-bind controlling fields (underscore notation, e.g. `dc_type`, `edm_type`) from `submit.type-bind.field`. */
+  getTypeFieldValues(): string[] {
+    return Array.from(this.typeFields.values());
+  }
+
 }

src/app/shared/mocks/form-builder-service.mock.ts

@@ -48,6 +48,7 @@ export function getMockFormBuilderService(): FormBuilderService {
     ),
     getTypeBindModelUpdates: EMPTY,
     resolveTypeBindModelId: undefined,
+    getTypeFieldValues: ['dc_type'],
   });
 
   // as the real implementation behaves for a reference the type field map does not remap

src/app/submission/sections/form/section-form.component.spec.ts

@@ -608,6 +608,36 @@ describe('SubmissionSectionFormComponent test suite', () => {
 
     });
 
+    it('should call dispatchSaveSection on form change when a type-bind field (e.g. dc.type) changes', () => {
+      spyOn(comp, 'hasStoredValue').and.returnValue(false);
+      formOperationsService.getFieldPathSegmentedFromChangeEvent.and.returnValue('dc.type');
+      formOperationsService.getFieldValueFromChangeEvent.and.returnValue({ value: 'Corpus' });
+
+      comp.onChange(dynamicFormControlEvent);
+
+      expect(submissionServiceStub.dispatchSaveSection).toHaveBeenCalledWith(submissionId, sectionObject.id);
+    });
+
+    it('should call dispatchSaveSection on form change when a sponsor value changes', () => {
+      spyOn(comp, 'hasStoredValue').and.returnValue(false);
+      formOperationsService.getFieldPathSegmentedFromChangeEvent.and.returnValue('local.sponsor');
+      formOperationsService.getFieldValueFromChangeEvent.and.returnValue({ value: 'EU' });
+
+      comp.onChange(dynamicFormControlEvent);
+
+      expect(submissionServiceStub.dispatchSaveSection).toHaveBeenCalledWith(submissionId, sectionObject.id);
+    });
+
+    it('should not call dispatchSaveSection on form change for a regular field', () => {
+      spyOn(comp, 'hasStoredValue').and.returnValue(false);
+      formOperationsService.getFieldPathSegmentedFromChangeEvent.and.returnValue('dc.description');
+      formOperationsService.getFieldValueFromChangeEvent.and.returnValue('some text');
+
+      comp.onChange(dynamicFormControlEvent);
+
+      expect(submissionServiceStub.dispatchSaveSection).not.toHaveBeenCalled();
+    });
+
     it('should set previousValue on form focus event', () => {
       formBuilderService.hasMappedGroupValue.and.returnValue(false);
       formOperationsService.getFieldValueFromChangeEvent.and.returnValue('test');

src/app/submission/sections/form/section-form.component.ts

@@ -52,6 +52,8 @@ import {
   isNotEmpty,
   isUndefined,
 } from '../../../shared/empty.util';
+import { AUTHOR_METADATA_FIELD_NAME } from '../../../shared/form/builder/ds-dynamic-form-ui/models/clarin-name.model';
+import { SPONSOR_METADATA_NAME } from '../../../shared/form/builder/ds-dynamic-form-ui/models/ds-dynamic-complex.model';
 import { FormBuilderService } from '../../../shared/form/builder/form-builder.service';
 import { FormFieldPreviousValueObject } from '../../../shared/form/builder/models/form-field-previous-value-object';
 import { FormComponent } from '../../../shared/form/form.component';
@@ -446,6 +448,13 @@ export class SubmissionSectionFormComponent extends SectionModelComponent {
     if ((environment.submission.autosave.metadata.indexOf(metadata) !== -1 && isNotEmpty(value)) || this.hasRelatedCustomError(metadata)) {
       this.submissionService.dispatchSave(this.submissionId);
     }
+
+    // Save immediately when a type-bind field (values like `dc_type`, `edm_type`) or a sponsor/author value changes.
+    const isTypeBindField = this.formBuilderService.getTypeFieldValues()
+      .some((typeValue) => typeValue === metadata.replace(/\./g, '_'));
+    if (isTypeBindField || [SPONSOR_METADATA_NAME, AUTHOR_METADATA_FIELD_NAME].includes(metadata)) {
+      this.submissionService.dispatchSaveSection(this.submissionId, this.sectionData.id);
+    }
   }
 
   private hasRelatedCustomError(medatata): boolean {