Skip to content

Commit 1534934

Browse files
committed
fix: fixed alignment of cells; overflowing the text in Name column
1 parent ad87426 commit 1534934

3 files changed

Lines changed: 22 additions & 11 deletions

File tree

src/app/item-page/edit-item-page/item-bitstreams/item-bitstreams.service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -366,13 +366,13 @@ export class ItemBitstreamsService {
366366
getColumnSizes(): ResponsiveTableSizes {
367367
return new ResponsiveTableSizes([
368368
// Name column
369-
new ResponsiveColumnSizes(2, 2, 3, 4, 4),
369+
new ResponsiveColumnSizes(3, 3, 3, 3, 3),
370370
// Description column
371-
new ResponsiveColumnSizes(2, 3, 3, 3, 3),
371+
new ResponsiveColumnSizes(3, 3, 3, 3, 3),
372372
// Format column
373373
new ResponsiveColumnSizes(2, 2, 2, 2, 2),
374374
// Actions column
375-
new ResponsiveColumnSizes(6, 5, 4, 3, 3),
375+
new ResponsiveColumnSizes(2, 2, 2, 2, 2),
376376
// Store synchronization columns
377377
new ResponsiveColumnSizes(2, 2, 2, 2, 2)
378378
]);

src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream-bundle/item-edit-bitstream-bundle.component.html

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<th id="{{ bundleName }}" class="span" colspan="3" scope="colgroup">
3939
{{'item.edit.bitstreams.bundle.name' | translate:{ name: bundleName } }}
4040
</th>
41-
<td class="text-center">
41+
<td class="{{ columnSizes.columns[3].buildClasses() }} text-center">
4242

4343
<div class="btn-group">
4444
<button [routerLink]="[itemPageRoute, 'bitstreams', 'new']"
@@ -77,7 +77,7 @@
7777
</div>
7878

7979
</td>
80-
<td></td>
80+
<td class="{{ columnSizes.columns[4].buildClasses() }}"></td>
8181
</tr>
8282

8383
<ng-container *ngFor="let entry of (tableEntries$ | async)">
@@ -86,12 +86,14 @@
8686

8787
<th class="bitstream-name row-element {{ columnSizes.columns[0].buildClasses() }}"
8888
scope="row" id="{{ entry.nameStripped }}" headers="{{ bundleName }} name">
89-
<div class="drag-handle text-muted float-left p-1 mr-2" tabindex="0" cdkDragHandle
90-
(keydown.enter)="select($event, entry)" (keydown.space)="select($event, entry)" (click)="select($event, entry)">
91-
<i class="fas fa-grip-vertical fa-fw"
92-
[title]="'item.edit.bitstreams.edit.buttons.drag' | translate"></i>
89+
<div class="d-flex align-items-center">
90+
<div class="drag-handle text-muted p-1 mr-2" tabindex="0" cdkDragHandle
91+
(keydown.enter)="select($event, entry)" (keydown.space)="select($event, entry)" (click)="select($event, entry)">
92+
<i class="fas fa-grip-vertical fa-fw"
93+
[title]="'item.edit.bitstreams.edit.buttons.drag' | translate"></i>
94+
</div>
95+
<span class="flex-grow-1 text-truncate bitstream-name-text" [title]="entry.name">{{ entry.name }}</span>
9396
</div>
94-
{{ entry.name }}
9597
</th>
9698
<td class="row-element {{ columnSizes.columns[1].buildClasses() }}"
9799
headers="{{ entry.nameStripped }} {{ bundleName }} description">
@@ -134,7 +136,7 @@
134136
</td>
135137
<td class="{{columnSizes.columns[4].buildClasses()}} row-element"
136138
headers="{{ entry.nameStripped }} {{ bundleName }} synchronized">
137-
<div class="d-flex align-items-center">
139+
<div class="d-flex align-items-center justify-content-center">
138140
<span class="text-center">
139141
<i [class]="isBitstreamSynchronized(entry) ? 'fas fa-check' : 'fas fa-times'"></i>
140142
</span>

src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream-bundle/item-edit-bitstream-bundle.component.scss

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,15 @@
1919
font-weight: normal;
2020
}
2121

22+
.bitstream-name-text {
23+
width: 0;
24+
overflow: auto;
25+
}
26+
2227
.table {
2328
margin-bottom: 0;
2429
}
30+
31+
.table thead th {
32+
vertical-align: middle;
33+
}

0 commit comments

Comments
 (0)