Skip to content

Commit 1791f81

Browse files
MatusBekeclaude
authored and
Matus Kasak
committed
UFAL/Fix self-delete tooltip being clipped by the EPeople table (#1373)
The disabled delete button's ngbTooltip renders inside the table's .table-responsive wrapper, which has overflow-x: auto — clipping the tooltip popover since the button sits near the table's right edge. Add container="body" so the tooltip is appended to <body> instead, escaping the overflow-clipped ancestor (same convention already used elsewhere in this codebase, e.g. health-status and orcid-queue). Fixes dataquest-dev/dspace-customers#800 Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> (cherry picked from commit 96209c4)
1 parent 488e888 commit 1791f81

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

‎src/app/access-control/epeople-registry/epeople-registry.component.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ <h2 id="search" class="border-bottom pb-2">
7474
</button>
7575
<ng-container *ngIf="epersonDto.ableToDelete && currentAuthenticatedUserId">
7676
<ng-container *ngIf="isCurrentUser(epersonDto.eperson); else enabledDeleteButton">
77-
<span tabindex="0" [ngbTooltip]="selfDeleteWarningLabel | translate">
77+
<span tabindex="0" [ngbTooltip]="selfDeleteWarningLabel | translate" container="body">
7878
<button [dsBtnDisabled]="true"
7979
tabindex="-1"
8080
[attr.aria-label]="selfDeleteWarningLabel | translate"

‎src/app/access-control/epeople-registry/eperson-form/eperson-form.component.html‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ <h1 class="border-bottom pb-2">{{messagePrefix + '.edit' | translate}}</h1>
4040
<span *ngIf="(canDelete$ | async) && (activeEPerson$ | async) as activeEPerson">
4141
<span *ngIf="isCurrentUser(activeEPerson); else enabledDeleteButton"
4242
tabindex="0"
43-
[ngbTooltip]="selfDeleteWarningLabel | translate">
43+
[ngbTooltip]="selfDeleteWarningLabel | translate"
44+
container="body">
4445
<button class="btn btn-danger delete-button" [dsBtnDisabled]="true" tabindex="-1" type="button">
4546
<i class="fas fa-trash"></i> {{'admin.access-control.epeople.actions.delete' | translate}}
4647
</button>

0 commit comments

Comments
 (0)